Skip to content

panfrost: Don't enable transaction elimination on disabled RTs

Boris Brezillon requested to merge bbrezillon/mesa:panfrost-no-crc-on-disabled-rt into master

The current logic can enable CRC writes even when the RT is disabled (write_enable = false), leading to a wrong checksum_valid state. Subsequent accesses to this resource will consider the CRC as valid and enable transaction elimination (crc_read_enable = true), potentially leading to an invalid RT state.

Patch 2 seems to fix dEQP-GLES2.functional.fbo.render.shared_colorbuffer.tex2d_rgba_stencil_index8 and dEQP-GLES2.functional.fbo.render.shared_colorbuffer.rbo_rgba4_depth_component16 seem to pass.

/cc @icecream95

Merge request reports