Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !920

vulkan/wsi: Improve mailbox X11 behavior

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Bas Nieuwenhuizen requested to merge bnieuwenhuizen/mesa:wsi-mailbox-wait into master May 20, 2019
  • Overview 17
  • Commits 4
  • Pipelines 6
  • Changes 3

This includes 2 functional changes for X11 mailbox behavior:

  • It waits till the GPU work is finished before sending the image to X11. Otherwise we can have issues as the GPU implicit fences are only checked on the queued images, which means that otherwise X11 does not correctly keep an idle image on hand.

  • Increase the image count to 5. KMS flip queueing + App pipelining of GPU/CPU each eat up one vs. the ideal 3.

With these changes Strange Brigade has the same performance between MAILBOX and IMMEDIATE.

Edited May 20, 2019 by Bas Nieuwenhuizen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wsi-mailbox-wait