Skip to content

radv: flush L2 for images affected by the pipe misaligned issue on GFX10+ (alt)

Bas Nieuwenhuizen requested to merge bnieuwenhuizen/mesa:alt-l2-fix into master

In some rare cases, L2 needs to be flushed if an image is affected by the pipe misaligned issue. This is roughly based on AMDVLK.

Confirmed that disabling TC-compat HTILE, and respectively DCC, for the relevant images also fixes the regressions below.

This fixes some regressions introduced with L2 coherency for dEQP-VK.renderpass2.depth_stencil_resolve.image_2d_* and for dEQP-VK.renderpass2.suballocation.multisample_resolve.*.

Base on work from Samuel Pitoiset with the following changes:

  • be more conservative if no image is passed in
  • Pass in image from subpass barrier to avoid that deoptimizing a lot. Conservatively did the entire framebuffer.
  • remove the power of 2 vram bus width check as we use the tcc_harvested bits for that.

Fixes: 4a783a3c ("radv: Use L2 coherency on GFX9+.")

Merge request reports