Skip to content

radv,aco: Compile with -Wshadow when available

Tony Wasserka requested to merge neobrain/mesa:wshadow into master

This helps prevent further issues like !7334 (merged) and !7388 (merged) in the future. The issue fixed in !7427 (merged) was flagged with by this diagnostic. Besides enabling -Wshadow itself, this MR fixes all the warnings currently flagged.

We're using some unhygienic macros (such as list_for_each_entry) that define variables with hardcoded variable names. These macros could be changed to generate unique variable names, but since this only affected two instances, I opted for just disabling the warning locally in aco.

(Also included two drive-by tiny code changes.)

Marked as Draft: since the external warning fixes in !7552 (merged) and !7632 (merged) should be merged first.

Edited by Tony Wasserka

Merge request reports

Loading