Skip to content

v3dv: VK_KHR_maintenance1

Iago Toral requested to merge itoral/mesa:v3dv_khr_maintenance1 into master

This extension adds:

Allow 2D and 2D array image views to be created from 3D images, which can then be used as color framebuffer attachments. This allows applications to render to slices of a 3D image.

Support vkCmdCopyImage between 2D array layers and 3D slices. This extension allows copying from layers of a 2D array image to slices of a 3D image and vice versa.

This series adds a few fixes to get these two working, and fixes a bug related to 3D image copies that while is not specific to this, was raised by CTS tests that were added with this extension.

Allow implementations to express support for doing just transfers and clears of image formats that they otherwise support no other format features for. This is done by adding new format feature flags VK_FORMAT_FEATURE_TRANSFER_SRC_BIT_KHR and VK_FORMAT_FEATURE_TRANSFER_DST_BIT_KHR.

We were already including these flags, so nothing to do.

Support vkCmdFillBuffer on transfer-only queues. Previously vkCmdFillBuffer was defined to only work on command buffers allocated from command pools which support graphics or compute queues. It is now allowed on queues that just support transfer operations.

We don't support transfer-only queues, so this doesn't change anything for us.

Fix the inconsistency of how error conditions are returned between the vkCreateGraphicsPipelines and vkCreateComputePipelines functions and the vkAllocateDescriptorSets and vkAllocateCommandBuffers functions.

We were already handling this correctly.

Add new VK_ERROR_OUT_OF_POOL_MEMORY_KHR error so implementations can give a more precise reason for vkAllocateDescriptorSets failures.

We were already doing this.

Add a new command vkTrimCommandPoolKHR which gives the implementation an opportunity to release any unused command pool memory back to the system.

This is trivial for us, since our command pools don't hold on to any command buffer resources.

I scanned the CTS for anything that checked for VK_KHR_maintenance1 and we seem to be passing all the relevant tests.

Merge request reports