Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
mesa
mesa
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,425
    • Issues 2,425
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 680
    • Merge Requests 680
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge Requests
  • !7182

Closed
Created Oct 16, 2020 by Timothy Arceri@tarceriDeveloper
  • Report abuse
Report abuse

util/disk_cache: do crc32 check on compressed data for ZSTD

  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 3

This will be faster and avoids checking for errors with the compression implementation which we shouldn't need to do. Instead we trust the compression library does the correct thing and simply error check the data loaded from disk. For reference this is the way the tool Fossilize does its crc checks on compressed archives.

For now this is only done for ZSTD as our zlib implementation doesn't always fully compress the cache items before writting parts of them to disk.

Edited Oct 16, 2020 by Timothy Arceri
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: compressed_crc