Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,047
    • Issues 3,047
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 990
    • Merge requests 990
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !6990

WIP: gallium/util: do not use undefined memory for texcoords

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Erik Faye-Lund requested to merge kusma/mesa:blitter-read-garbage-fix into master Oct 02, 2020
  • Overview 10
  • Commits 1
  • Pipelines 2
  • Changes 1

blitter_context_priv::vertices is initialized at start-up, but can (and will) be overwritten by calls to the blitter since then. Since we always copy from the LOD read by the the vertex-shader, and we risk blitting from out-of-range LODs, which give incorrect results.

So let's just bite the bullet and not use the XY-codepath in the shared code. The difference is just a few writes, but then we always update all the read state as apropriate.

This fixes a case for me where the following two Khronos Confidental CTS cases are run back to back:

GTF-GL33.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_error_blitframebuffer_multisampled_framebuffers_different_formats GTF-GL33.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_nearest_filter_color_blit

Fixes: 22ed1ba0 ("gallium/u_blitter: use draw_rectangle for all blits except cubemaps")

Edited Dec 16, 2020 by Erik Faye-Lund
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: blitter-read-garbage-fix