Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
mesa
mesa
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,326
    • Issues 2,326
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 637
    • Merge Requests 637
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Mesa
  • mesamesa
  • Merge Requests
  • !6969

Merged
Opened Oct 01, 2020 by Matt Turner@mattst88Owner

Revert F16C series (MR 6774)

  • Overview 2
  • Commits 1
  • Pipelines 5
  • Changes 45

This reverts commit 4fb2eddf. This reverts commit 7a1deb16. This reverts commit 2b6a1723. This reverts commit 5af81393. This reverts commit 87900afe.

A couple of problems were discovered after this series was merged that cause breakage in different configurations:

(1) It seems that using -mf16c also enables AVX, leading to SIGILL on platforms that do not support AVX. (2) Since clang only warns about unknown flags, and as I understand it Meson's handling in cc.has_argument() is broken, the F16C code is wrongly enabled when clang is used, even for example on ARM, leading to a compilation error.

Closes: #3583 (closed)

cc: @mareko, @pepp, @robclark, @anholt

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: mesa/mesa!6969
Source branch: revert-f16c