Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
mesa
mesa
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,316
    • Issues 2,316
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 630
    • Merge Requests 630
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Mesa
  • mesamesa
  • Merge Requests
  • !6597

Merged
Opened Sep 04, 2020 by Daniel Schürmann@daniel-schuermannDeveloper

nir: replace .lower_negate with .lower_ineg and .lower_sub with .has_fsub and .has_isub

  • Overview 23
  • Commits 2
  • Pipelines 33
  • Changes 22

These changes allow a more fine-grained control about the backends supporting these instructions.

The previous lower_negate option lowered both ineg and fneg. The fneg semantics have been clarified as of Version 1.5, Revision 1 of the SPIR-V specification, which means that the previous lowering to fsub is not a viable solution anymore. (I added the lowering manually to vc4, but eventually it should be changed.)

In a second step, the goal is to introduce an alternative fsub lowering using fmul(x, -1.0). (see !5523)

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: mesa/mesa!6597
Source branch: aco_ineg