Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !5728

util: format pack/unpack cleanups again

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Emma Anholt requested to merge anholt/mesa:format-cleanups into master Jul 03, 2020
  • Overview 4
  • Commits 14
  • Pipelines 8
  • Changes 26

I've got a branch I'm working on that splits apart format pack/unpack so that drivers (particularly vulkan drivers) that don't use one of those groups of generated code can successfully garbage collect them. This is not that branch.

In the process of disentangling, I kept running into "this would be so much easier if this dead/duplicated code wasn't here", and generating more commits, and I wanted to carve this chunk off to merge first.

Size reductions from this in the release builds I use:

  • -21696b aarch64 dri.so
  • -17400b aarch64 libvulkan_freedreno.so
  • -9320b i965_dri.so
  • -8072b gallium dri.so
  • -9308b libvulkan_intel.so
Edited Jul 03, 2020 by Emma Anholt
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: format-cleanups