Skip to content

spirv: Re-emit constants at their uses

Faith Ekstrand requested to merge gfxstrand/mesa:review/spirv-imm-on-the-fly into main

Right now, spirv_to_nir places all constants at the top of the function and has a hash table to de-duplicate them. This change drops the hash table and starts re-emitting constants more-or-less at their uses. This is more consistent with what we do in GLSL -> NIR translation. It is, however, a change to SPIR-V -> NIR translation which will likely affect other optimizations in unexpected ways so it should be evaluated separately.

Merge request reports