Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,058
    • Issues 3,058
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,003
    • Merge requests 1,003
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !4388

aco: Compact LDS usage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timur Kristóf requested to merge Venemo/mesa:aco-compact-lds into master Mar 31, 2020
  • Overview 55
  • Commits 9
  • Pipelines 22
  • Changes 9

This MR reduces the LDS usage of ACO by about 35% by packing the driver locations closer together. Depends on !4351 (merged) for correct behaviour.

  1. In order to be able to pack the driver locations, a new NIR linking helper is introduced which looks at the outputs of a producer and the inputs of a consumer and creates a mask from both of them. This mask is then used for assigning driver locations. The new linking helper can be used by other drivers as well, if they so desire.
  2. RADV makes use of the new NIR linking helper for assigning default driver locations to I/O variables before shader compilation.
  3. ACO will use the new default driver locations, and it also uses the number of linked I/O variables for determining the TCS input/output size, which the LDS size calculation is based on. The ESGS item size is also adjusted.
Edited Apr 28, 2020 by Timur Kristóf
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: aco-compact-lds