Skip to content

intel/fs: Fix opt_peephole_csel to not throw away saturates.

Kenneth Graunke requested to merge kwg/mesa:csel-fix into master

We were not copying the saturate bit from the original instruction to the new replacement instruction. This caused major misrendering in DiRT Rally on iris, where comparisons leading to discards failed due to the missing saturate, causing lots of extra garbage pixels to be drawn in text rendering, trees, and so on.

This did not show up on i965 because st/nir performs a more aggressive version of nir_opt_peephole_select, yielding more b32csel operations.

Fixes: 52c7df16 i965/fs: Merge CMP and SEL into CSEL on Gen8+

Merge request reports