Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,065
    • Issues 3,065
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 994
    • Merge requests 994
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !4294

egl/wayland: Fix zwp_linux_dmabuf usage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christopher James Halse Rogers requested to merge RAOF/mesa:fix-2220 into master Mar 24, 2020
  • Overview 29
  • Commits 1
  • Pipelines 13
  • Changes 1

There's no guarantee that the formats advertised by wl_drm and the formats advertised by zwp_linux_dmabuf_v1 are the same.

get_back_bo() handles this by falling back from createImageWithModifiers() to createImage() when there's a wl_drm format but no corresponding linux_dmabuf format, but create_wl_buffer() unconditionally tries to create a linux_dmabuf buffer unless DRIimage has DRM_FORMAT_MOD_INVALID.

Fix this by always checking if the DRIimage modifier has been advertised by zwp_linux_dmabuf_v1, and falling back to wl_drm if not.

Closes: #2220 (closed) Signed-off-by: Christopher James Halse Rogers christopher.halse.rogers@canonical.com

Edited Mar 25, 2020 by Christopher James Halse Rogers
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-2220