Skip to content

anv: Push UBO ranges relative to the start of the binding

Faith Ekstrand requested to merge gfxstrand/mesa:review/anv-fix-rba into master

There was a disconnect between anv_nir_compute_push_layout and the code which sets up the push_ubo_sizes array. The NIR code we emit checks relative to the start of the bound UBO range so that, if we end up with a vector which straddles the start of the push range, we can perform the bounds check without risking overflow issues. The code which sets up the push_ubo_sizes, on the other hand, assumed it was relative to the start of the push range. Somehow, this didn't get get caught by any of the available tests.

Merge request reports