Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !3429

panfrost/midgard: Fix swizzle for store instructions

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Boris Brezillon requested to merge bbrezillon/mesa:panfrost-midgard-fix-store-swizzle into master Jan 16, 2020
  • Overview 2
  • Commits 1
  • Pipelines 6
  • Changes 1

The current logic considers that the nir_intrinsic_component(store_intr) encodes the source components start, but it actually encodes the destination one. Source component offset adjustment is taken care of in install_registers_instr(), when offset_swizzle() is called.

This fixes dEQP-GLES2.functional.shaders.random.all_features.fragment.45 when PAN_MESA_DEBUG=deqp (looks like exposing GLES3 features has an impact on the varyings layout).

Signed-off-by: Boris Brezillon boris.brezillon@collabora.com /cc @alyssa @tomeu

Edited Jan 17, 2020 by Alyssa Rosenzweig
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: panfrost-midgard-fix-store-swizzle