Skip to content

iris: Fix value of out-of-bounds accesses for vertex attributes

Danylo Piliaiev requested to merge GL/mesa:fix/iris/vb-attribute-buffer-size-v2 into master

Having VERTEX_BUFFER_STATE.BufferSize greater than the size of a bound vertex buffer allows shader to read uninitialized vertex attributes from BO, instead of allowing hardware to return zeroes on out-of-bounds access.

OpenGL spec "6.4 Effects of Accessing Outside Buffer Bounds" says:

"Robust buffer access can be enabled by creating a context with robust access
 enabled through the window system binding APIs. When enabled, any command
 unable to generate a GL error as described above, such as buffer object accesses
 from the active program, will not read or modify memory outside of the data
 store of the buffer object and will not result in GL interruption or termination.
 Out-of-bounds reads may return values from within the buffer object or zero
 values."

Fixes three webgl tests:
conformance/rendering/out-of-bounds-array-buffers.html
conformance2/rendering/out-of-bounds-index-buffers-after-copying.html
conformance2/rendering/element-index-uint.html

See #1996

Passes CI: https://mesa-ci.01.org/global_logic/builds/239/group/63a9f0ea7bb98050796b649e85481845

@ickle I added you as Signed-off since it's your suggestion.

Merge request reports