Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !3394

Move the aux transition state machine code to ISL

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Faith Ekstrand requested to merge gfxstrand/mesa:wip/isl-aux-helpers into master Jan 14, 2020
  • Overview 3
  • Commits 5
  • Pipelines 24
  • Changes 9

This MR a prototype for Moves a bunch of the duplicated aux code in i965 and iris to ISL. It's very similar to !2957 (merged) with a few differences:

  1. Instead of copying the interface used by i965, it makes things look a bit more like Vulkan. In order to unify things into a single "transition" function, I added a new ISL_AUX_OP_DRAW which I think worked out well.
  2. I made no attempt to make aux "nicer" by adding a metadata table. Instead I just added a couple of useful helper functions. This is likely not a good thing; I think some sort of "how does this type of aux work?" metadata table is a good idea; I was more focussed on the external ISL interface so I did the minimal thing.
Edited Jan 16, 2020 by Faith Ekstrand
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/isl-aux-helpers