Skip to content

tu,ir3: Fixes for VK_KHR_fragment_shading_rate

Danylo Piliaiev requested to merge Danil/mesa:turnip/fix/VK_KHR_fragment_shading_rate into main

What does this MR do and why?

tu: Disable fragmentShadingRateWithShaderSampleMask due to issues

FSR with VK_EXT_post_depth_coverage enabled has wrong values of
gl_SampleMaskIn[0]. Prop driver has fragmentShadingRateWithShaderSampleMask
enabled, but it doesn't support VK_EXT_post_depth_coverage.

Sample mask is supplied by HW and there is no flag in sight to fix it.

The failing tests were:
 dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.sample_mask_with_depth_test.samples_2_post_depth_coverage
 dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.sample_mask_with_depth_test.samples_4_post_depth_coverage
 dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.sample_mask_with_depth_test.samples_2_post_depth_coverage
 dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.sample_mask_with_depth_test.samples_4_post_depth_coverage
 dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.sample_mask_with_depth_test.samples_2_post_depth_coverage
 dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.sample_mask_with_depth_test.samples_4_post_depth_coverage

Fixes: 2ab8eff511d640e50682965eb5d4cd9e28f78487
("tu/a7xx: Implement VK_KHR_fragment_shading_rate")
tu,ir3: Add workaround for reading shading rate on A7XX gen1,gen2

On A7XX reading fragment shading rate correctly requires declare
SAMPLEMASK input. It doesn't need to be used anywhere, just declared.

This workaround was seen in the prop driver v512.762.12

Fixes a lot of tests in:
 dEQP-VK.fragment_shading_rate.*

Fixes: 2ab8eff5
("tu/a7xx: Implement VK_KHR_fragment_shading_rate")

Merge request reports