Skip to content

glsl: apply implicit matching restrictions when linking

Timothy Arceri requested to merge tarceri/mesa:implicit_function_params into main

Older versions of the glsl spec do not allow certain or any implicit matching of function params. Currently mesa was only applying the restrictions at compile time and when matching functions between separate shaders of the same stage it was allowing implicit matching in all versions of glsl.

This series tightens things up and applies the rules during linking also. Note this series could cause real world shaders to start failing as no other driver seems to actually apply the restrictions on glsl 1.10. But for existing programs with the issue the allow_glsl_120_subset_in_110 workaround will continue to work for the new link time checks also.

Piglit tests: piglit!945 (merged)

Edited by Timothy Arceri

Merge request reports

Loading