Skip to content

rusticl/queue: fix error propagation and set_constant_buffer_stream

Karol Herbst requested to merge karolherbst/mesa:rusticl/issue/11485 into main

This fixes a couple of issues I've found while investigating #11485 (closed)

  • set_constant_buffer_stream didn't set take_ownership to true, even though it should. This fixes the original bug report.
  • handles failures with u_upload_data, which can happen on out of memory situation, so we can just return CL_OUT_OF_RESOURCES
  • events which run into an error inside their work item get their status set to CL_RUNNING and CL_COMPLETE later.
  • dependencies from the same queue were ignored when checking for an error.
  • CL_EXEC_STATUS_ERROR_FOR_EVENTS_IN_WAIT_LIST didn't take errors into account happening in the work item.
  • blocking commands didn't return execution errors.

Merge request reports