Skip to content

panfrost: change default rounding mode for samplers

Eric Smith requested to merge ericsmith/mesa:ericsmith/valhall_coordinate_rounding into main 
panfrost: change default rounding mode for samplers

The SamplerDescriptor structure has a field which describes how
floating point coordinates should be converted to fixed point.
Setting this to "true" (which causes round to nearest even) fixes
a failing CTS test.

The CTS test in question is:
dEQP-GLES31.functional.texture.border_clamp.range_clamp.linear_float_color

The OpenGL spec is somewhat vague about how rounding is to be
performed, so it appears both settings should be legal; this may
indicate a problem with the CTS. Nevertheless "round to nearest even"
is probably a better default and since it fixes the failing test we
may as well use it.

Cc: mesa-stable
Edited by Eric Smith

Merge request reports