Skip to content

nvk: Always copy conditional rendering value before compare

Mary Guillemard requested to merge marysaka/mesa:nvk/fix-condrender into main

The spec requires a compare on 32-bit but the hardware actually compare 64-bit.

As such, we are required to copy the value to a temporary buffer before the compare.

This fixes new failures introduced by VKCTS 1.3.8.0 new tests:

dEQP-VK.conditional_rendering.transform_feedback.draw
dEQP-VK.conditional_rendering.transform_feedback.draw_indexed
dEQP-VK.conditional_rendering.transform_feedback.draw_indexed_indirect
dEQP-VK.conditional_rendering.transform_feedback.draw_indexed_indirect_count
dEQP-VK.conditional_rendering.transform_feedback.draw_indirect
dEQP-VK.conditional_rendering.transform_feedback.draw_indirect_byte_count_ext
dEQP-VK.conditional_rendering.transform_feedback.draw_indirect_count
dEQP-VK.conditional_rendering.transform_feedback.draw_multi_ext
dEQP-VK.conditional_rendering.transform_feedback.draw_multi_indexed_ext

Merge request reports