Skip to content

anv: fix non matching image/view format attachment resolve

Lionel Landwerlin requested to merge llandwerlin/mesa:review/anv-non-match-image-view-attachment-resolve into main

What does this MR do and why?

anv: fix non matching image/view format attachment resolve

Let's say you have an image in R32_UINT format, a view is created in
R32_SFLOAT and used as color attachment.

When resolving the attachment, our current code uses the image format
(R32_UINT in this case). But resolve mode might apply only to SFLOAT,
so we currently run into an assert in blorp.

We should instead use the view format. There is an exception for
depth/stencil view because the format we want to resolve is actually
the depth/stencil format, not just the depth or stencil aspect.

This fixes vkd3d-proton's test_multisample_resolve_formats.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable

Merge request reports