Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,075
    • Issues 3,075
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,007
    • Merge requests 1,007
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • MesaMesa
  • mesamesa
  • Merge requests
  • !20869

gallium/draw: Enable other Boolean types for aapoint and polygon stipper draw helpers

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ian Romanick requested to merge idr/mesa:review/draw_helpers into main Jan 24, 2023
  • Overview 5
  • Commits 2
  • Pipelines 5
  • Changes 11

This came out of discussions about Boolean type weirdness in !20509 (merged). Basically, all of these helpers assume they're being run after nir_lower_bool_to_int32 on hardware that wants that. However, dozen does not want that, and it had just been working by luck.

While investigating that, I noticed that i915 has needs that aren't being met by these passes. It wants Boolean values as float32, and this mismatch causes it to crash on AA point tests. D'oh!

These changes allow drivers using these helpers to specify what kind of Boolean values it wants for AA points and polygon stipple. Those seem to be the only cases that generate Booleans.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: review/draw_helpers