Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,083
    • Issues 3,083
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,001
    • Merge requests 1,001
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • MesaMesa
  • mesamesa
  • Merge requests
  • !20475

v3dv: initialize fd variable for proper error handling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Maíra Canal requested to merge mairacanal/mesa:v3dv/error_handling into main Jan 02, 2023
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

Currently, process_singlesync_signals() checks if fd == -1 to handle possible errors in the drmSyncobjExportSyncFile function. But, fd is not initialized, which means that drmSyncobjExportSyncFile might fail and the error will not be handled as fd might not be equal to -1.

Therefore, initialize the fd variable with value -1 to ensure proper error handling.

Signed-off-by: Maíra Canal mcanal@igalia.com

cc @andrealmeid @mwen

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v3dv/error_handling