Skip to content

CI/Windows: Built piglit with Waffle

Jesse Natalie requested to merge jenatali/mesa:piglit-waffle into main

This is a revival of !14084 (closed).

There's a few interesting test result transitions here:

  • Warn -> pass/fail/crash - these are tests that refused to run, and with the piglit runner instead of deqp-runner, they'd be marked as failed instead of warn. Now we can see the real test results. Since warns aren't listed in the failures/baselines, these can show up as "new" failures from this change, but they were just hidden before.
  • Fail -> pass - there's some windowing differences between GLUT and Waffle, which caused Mesa to actually get valid window dimensions with GLUT where Waffle sees (0, 0). For tests that ask for a small window, that's problematic, because Windows has minimum dimensions, and so the GLUT case ended up setting an implicit viewport that didn't match the test's expected implicit viewport (e.g. 120x60 instead of 1x1), which caused some test failures.
  • Missing (skipped) -> pass/fail - some tests (e.g. WGL) only build with Waffle.
  • Pass/fail -> missing (skipped) - some tests only build with GLUT.

Overall, this gets us a clearer picture of what our results actually are, and uses a fellow freedesktop project instead of a 3rd party one, so it seems like a win across the board.

Edited by Jesse Natalie

Merge request reports