Skip to content

panfrost: Remove experimental v7-only indirect draw path

Alyssa Rosenzweig requested to merge alyssa/mesa:panfrost/remove-some into main

There are too many problems with indirect draws on v7 that we never got this code path to the finish line, and none of us have a good plan (or reason) to fix this. Proper indirect draws are only possible since v10 on Mali.

There was interest in using this path to implement indexed draws in PanVK, that MR is stalled and it's not clear how much sense it makes to do Vulkan on anything older than v9 or v10 at this point. This code isn't gone, it'll still be in git history, but I don't see a lot of reason in keeping it in tree if it's unused and complicating e.g. the sysval upload path of the driver.

Indirect dispatch remains supported on v7, as that path is working and flipped on for end users. Indirect dispatch on v7 is considerably less complicated than indirect draws.

I talked to @bbrezillon (who wrote this code originally) who agreed this was probably the right call. I'm not thrilled about it but yeah.

Merge request reports