Skip to content

vulkan/runtime: fix wrapper for vkCmdSetEvent

Iago Toral requested to merge itoral/mesa:vk_fix_set_event into main

We had been using stageMask for both the srcStageMask and dstStageMask of the barrier, however the mask taken in vkCmdSetEvent represents a source stage mask:

"stageMask specifies the source stage mask used to determine the first synchronization scope"

And we don't know the dstStageMask, so we need to include all stages.

I found this by inspection, but I think it might be the reason I am seeing some some flakes in CTS runs with v3dv for some event sync tests since we changed our implementation of events in the driver.

@jekstrand: I believe this is exactly the reason why vkCmdSetEvent2 was added, no?

Edited by Iago Toral

Merge request reports