Skip to content

frontends/va: fixed an av1 dec image corruption.

Ruijing Dong requested to merge rdong/mesa-rdong-2021:av1_key_showframe into main

[problem] When decoding an av1 bitstream, it shows image corruption in the middle of the bitstream around key frames.

[analysis] in av1_spec.pdf page 38/669, there is a sentence below:

if ( frame_type == KEY_FRAME && show_frame ) { for ( i = 0; i < NUM_REF_FRAMES; i++) { RefValid[ i ] = 0 ...... } ...... }

This shows that the condition of invalidating current DPB frames should be the coming frame_type is KEY_FRAME plus show_frame is equal to 1. Otherwise, some of the frames in sequence after KEY_FRAME still refer to the reference frames before KEY_FRAME, and if these before KEY_FRAME reference frames were invalidated, these frames could not find their reference frames, and it could cause image corruption.

[solution] Add condition of show_frame, with the corresponding fix in ffmpeg, we cannot see this issue any longer.

Signed-off-by: Ruijing Dong ruijing.dong@amd.com

Merge request reports