Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,059
    • Issues 3,059
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,002
    • Merge requests 1,002
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !1871

WIP: nir: improvements over Eric's prepass scheduling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Alejandro Piñeiro requested to merge apinheiro/mesa:review/nir-schedule-load-shared-support into master Sep 04, 2019
  • Overview 13
  • Commits 6
  • Pipelines 7
  • Changes 5

Added a WIP because the main patch is already included on MR !301 (merged) . Current MR just add support to load_shared, so @anholt can take a look to it, and provide early feedback just in case it is wrong.

That change allows the following 3.1 ES CTS test passing:

  • KHR-GLES31.core.compute_shader.shared-max

But the patch that introduces the nir scheduler introduces regressions on the following tests (so another reason for the WIP)

  • KHR-GLES31.core.shader_image_load_store.advanced-allMips-fs
  • KHR-GLES31.core.shader_image_load_store.advanced-copyImage-fs
  • KHR-GLES31.core.shader_image_load_store.advanced-sso-simple
  • KHR-GLES31.core.shader_image_load_store.advanced-sync-imageAccess2
  • KHR-GLES31.core.shader_image_load_store.basic-allFormats-load-fs
  • KHR-GLES31.core.shader_image_load_store.basic-allFormats-store-fs

I plan to take a look to those.

Final note: in order to check that the load_shared is not moved if there are a store_shared between the original and the new position of the load_shared, I wrote this small test: piglit!126 (merged)

UPDATE: as time passed I have been adding some improvements, so I have just changed the title of the issue.

Edited Nov 24, 2019 by Alejandro Piñeiro
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: review/nir-schedule-load-shared-support