Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,879
    • Issues 2,879
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 906
    • Merge requests 906
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge requests
  • !1782

Closed
Created Aug 27, 2019 by Caio Oliveira@cmarceloDeveloper
  • Report abuse
Report abuse

anv, nir: Fix using shared memory bools

  • Overview 10
  • Commits 2
  • Pipelines 2
  • Changes 2

After we started to use derefs for shared memory in Anv, we are crashing when seeing a shared memory boolean. This happens because neither lower_explicit_io or lower_memory_access_bit_sizes handled bit_size == 1 case properly. Solution proposed is to act as they are effectively 32 bit data -- which is assumed elsewhere and which they will eventually be lowered to.

This MR fixes 024a46a4 ("anv: use derefs for shared memory access") and will also fix an upcoming test in Crucible: crucible!49 (merged).

Edited Aug 27, 2019 by Caio Oliveira
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: r/anv-fix-shared-memory-bools