Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,070
    • Issues 3,070
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,001
    • Merge requests 1,001
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !17128

agx: Handle loop { if { loop { .. } } }

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alyssa Rosenzweig requested to merge asahi/mesa:asahi/agx-bugs into main Jun 19, 2022
  • Overview 0
  • Commits 1
  • Pipelines 4
  • Changes 1

We need to push loop nesting to handle this correctly -- at the end of the innermost loop, the correct nesting is 1 (from the if), not 0.

Fixes assertion failure in

dEQP-GLES2.functional.shaders.struct.local.dynamic_loop_nested_struct_array_fragment,UnexpectedPass dEQP-GLES2.functional.shaders.struct.local.dynamic_loop_nested_struct_array_vertex,UnexpectedPass dEQP-GLES2.functional.shaders.struct.uniform.dynamic_loop_nested_struct_array_fragment,UnexpectedPass dEQP-GLES2.functional.shaders.struct.uniform.dynamic_loop_nested_struct_array_vertex,UnexpectedPass

Signed-off-by: Alyssa Rosenzweig alyssa@rosenzweig.io

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: asahi/agx-bugs