Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,780
    • Issues 2,780
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 945
    • Merge requests 945
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge requests
  • !16201

panfrost: Unify row strides

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alyssa Rosenzweig requested to merge alyssa/mesa:always-row-stride into main Apr 27, 2022
  • Overview 2
  • Commits 14
  • Pipelines 8
  • Changes 13

For a given image, only 1 of "line stride", "(interleaved/block-compressed) row stride", or "AFBC row stride" makes sense. Yet we have all 3 fields separately, breeding confusion. This MR unifies the three into a single row stride field which generally means "the number of bytes between rows".

Unfortunately, this isn't completely trivial, because we accidentally made some broken stride definitions UABI... Whoops! To cope, add a pair of helpers to translate between legacy (UABI) strides and row strides. This should make the intent clear.

Cc @bbrezillon for the panvk changes.

Cc @anarsoul @enunes for the lima changes... Lima may consider a similar change set but I'm not committing myself to this 😄

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: always-row-stride