Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !13418

WIP: nir: Add variable modes for textures and atomic counters

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Faith Ekstrand requested to merge gfxstrand/mesa:wip/nir-var-texture into main Oct 18, 2021
  • Overview 0
  • Commits 19
  • Pipelines 10
  • Changes 19

This is similar to !4743 (merged) only for textures and atomic counters. Everything associated with texturing will go in nir_var_texture: textures, samplers and combined texture+sampler. We could split hairs and try to separate samplers and textures but then we have a bit of a mess for combined sampler+texture variables.

One thing here that's a bit non-obvious: When coming from GLSL, samplers are in nir_var_uniform until lower_samplers_as_deref() is called. This is a bit awkward but required right now as GLSL allows samplers to live inside structs with other stuff. I'm starting to wish that had been written as a GLSL lowering pass.....

Edited Oct 18, 2021 by Faith Ekstrand
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/nir-var-texture