Skip to content

mesa: check for valid internalformat with glTex[Sub]Image

Tapani Pälli requested to merge tpalli/mesa:fix-7141c into main 
This changes our error handling to be compatible with upcoming
specification change that unifies glTex[Sub]Image error handling
between OpenGL ES 2.0 vs ES 3.0+ specifications, see:

https://gitlab.khronos.org/opengl/API/-/issues/147

OpenGL ES 2.0.25 spec states:

   "Specifying a value for internalformat that is not one of
    the above values generates the error INVALID_VALUE. If
    internalformat does not match format, the error
    INVALID_OPERATION is generated."

This fixes following new tests:

    KHR-GLES31.core.compressed_format.*
    KHR-GLES32.core.compressed_format.*

v2: GL_INVALID_OPERATION -> GL_INVALID_VALUE in extension
    checks (Eric Anholt)

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Edited by Tapani Pälli

Merge request reports