Skip to content

broadcom/qpu: version field at opcode_desc is being ignored

Alejandro Piñeiro requested to merge apinheiro/mesa:wip/apinheiro/opcode-desc-ver-ignored into main

qpu_pack defines a opcode description structure that it is used when packing/unpacking. One of the fields is the hw version where that opcode got defined. In theory that can be used to mark if the opcode changed across V3D versions, that could be used for things like:

  • Mark when an opcode got defined first, so older hw generation shouldn't use it
  • Mark when an opcode changes across hw versions. That means that the opcode table could have defined the same opcode several times.
  • etc

But the reality is that the version field is not used at all. This MR handles that, and as we are here, includes a minor comment cleanup.

Merge request reports