Skip to content
GitLab

tu: Raise maxDescriptorSetUpdateAfterBindUniformBuffersDynamic to 16

Merged Matt Turner requested to merge mattst88/mesa:turnip-reduce-MAX_DYNAMIC_UNIFORM_BUFFERS into main

... and reduce maxDescriptorSetUpdateAfterBindStorageBuffersDynamic from 12 to 8.

MAX_DYNAMIC_BUFFERS is MAX_DYNAMIC_UNIFORM_BUFFERS + MAX_DYNAMIC_STORAGE_BUFFERS. We set

maxDescriptorSetUniformBuffersDynamic = MAX_DYNAMIC_UNIFORM_BUFFERS
maxDescriptorSetStorageBuffersDynamic = MAX_DYNAMIC_STORAGE_BUFFERS
maxDescriptorSetUpdateAfterBindUniformBuffersDynamic = MAX_DYNAMIC_BUFFERS / 2
maxDescriptorSetUpdateAfterBindStorageBuffersDynamic = MAX_DYNAMIC_BUFFERS / 2

The CTS test checks that

maxDescriptorSetUpdateAfterBindUniformBuffersDynamic

  • is at least 8; and
  • is at least maxDescriptorSetUniformBuffersDynamic

maxDescriptorSetUpdateAfterBindStorageBuffersDynamic

  • is at least 4; and
  • and is at least maxDescriptorSetStorageBuffersDynamic

Prior to this patch maxDescriptorSetUpdateAfterBindUniformBuffersDynamic was 12 but maxDescriptorSetUniformBuffersDynamic was 16, thus causing the CTS failure in dEQP-VK.api.info.vulkan1p2_limits_validation.ext_descriptor_indexing

By raising maxDescriptorSetUpdateAfterBindUniformBuffersDynamic to the same value as maxDescriptorSetUniformBuffersDynamic, we bring the limits into the appropriate ranges. We do the same thing for maxDescriptorSetUpdateAfterBindStorageBuffersDynamic by assigning it the same value as maxDescriptorSetStorageBuffersDynamic.

Edited by Matt Turner