Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,065
    • Issues 3,065
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,011
    • Merge requests 1,011
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

Update #1:

Due to abusive users subverting our CI facilities to mine cryptocurrency, breaking out of the container sandbox in the process, we have been forced to take actions to limit the usage of the public runners to official projects only.

The policy will be enforced on 2023-03-23 (or before if we detect abuses).

Please see this issue for more context and to see if and how you are impacted.

  • MesaMesa
  • mesamesa
  • Merge requests
  • !1152

glsl: Don't increase the iteration count when there are no terminators

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ian Romanick requested to merge idr/mesa:review/bug-110953 into master Jun 21, 2019
  • Overview 1
  • Commits 1
  • Pipelines 3
  • Changes 1

Incrementing the iteration count was intended to fix an off-by-one error when the first terminator was superseded by a later terminator. If there is no first terminator or later terminator, there is no off-by-one error. Incrementing the loop count creates one. This can be seen in loops like:

do {
    if (something) {
        // No breaks or continues here.
    }
} while (false);

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110953
Fixes: 646621c6 ("glsl: make loop unrolling more like the nir unrolling path")
Cc: Timothy Arceri tarceri@itsqueeze.com @tarceri

Edited Jun 21, 2019 by Ian Romanick
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: review/bug-110953