Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,080
    • Issues 3,080
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,017
    • Merge requests 1,017
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • MesaMesa
  • mesamesa
  • Issues
  • #64
Closed
Open
Issue created Sep 18, 2019 by Bugzilla Migration User@bugzilla-migration

dereference before null check src/glx/dri2_glx.c:617

Submitted by Vinson Lee

Assigned to Kristian H. Kristensen @krh

Link to original bug (#29181)

Description

mesa: 62f8b56d (master)

617: "pdraw" directly dereferenced 621: "pdraw" null check

Either 617 could be a null dereference or the 621 null check in unnecessary.

src/glx/dri2_glx.c 612 _X_HIDDEN void 613 dri2InvalidateBuffers(Display *dpy, XID drawable) 614 { 615 __GLXDRIdrawable *pdraw = 616 dri2GetGlxDrawableFromXDrawableId(dpy, drawable); -> 617 struct dri2_screen *psc = (struct dri2_screen *) pdraw->psc; 618 struct dri2_drawable *pdp = (struct dri2_drawable *) pdraw; 619
620 #if __DRI2_FLUSH_VERSION >= 3 -> 621 if (pdraw && psc->f) 622 psc->f->invalidate(pdp->driDrawable); 623 #endif 624 }

Version: git

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking