Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,062
    • Issues 3,062
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 994
    • Merge requests 994
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Issues
  • #324
Closed
Open
Issue created Sep 18, 2019 by Bugzilla Migration User@bugzilla-migration

[swrast] piglit getteximage-formats regression

Submitted by Vinson Lee

Assigned to mes..@..op.org

Link to original bug (#97569)

Description

mesa: 72b56e8b (master 12.1.0-devel)

$ ./bin/getteximage-formats -auto getteximage-formats failure: format: GL_SRGB_EXT, level 1 at pixel(369, 103) Expected (0.992157, 0.992157, 0.501961, 1.000000) Found (0.972549, 0.972549, 0.215686, 1.000000) Tolerance (0.031250, 0.031250, 0.031250, 0.250000) getteximage-formats failure: format: GL_SRGB_EXT, level 2 at pixel(421, 71) Expected (0.992157, 0.992157, 0.501961, 1.000000) Found (0.956863, 0.956863, 0.215686, 1.000000) Tolerance (0.031250, 0.031250, 0.031250, 0.250000) getteximage-formats failure: format: GL_SRGB8_EXT, level 1 at pixel(369, 103) Expected (0.992157, 0.992157, 0.501961, 1.000000) Found (0.972549, 0.972549, 0.215686, 1.000000) Tolerance (0.031250, 0.031250, 0.031250, 0.250000) getteximage-formats failure: format: GL_SRGB8_EXT, level 2 at pixel(421, 71) Expected (0.992157, 0.992157, 0.501961, 1.000000) Found (0.956863, 0.956863, 0.215686, 1.000000) Tolerance (0.031250, 0.031250, 0.031250, 0.250000) getteximage-formats failure: format: GL_SRGB_ALPHA_EXT, level 1 at pixel(369, 103) Expected (0.690273, 0.690273, 0.449981, 0.240292) Found (0.678431, 0.678431, 0.305882, 0.239216) Tolerance (0.031250, 0.031250, 0.031250, 0.031250) getteximage-formats failure: format: GL_SRGB_ALPHA_EXT, level 2 at pixel(421, 71) Expected (0.690273, 0.690273, 0.449981, 0.240292) Found (0.670588, 0.670588, 0.305882, 0.239216) Tolerance (0.031250, 0.031250, 0.031250, 0.031250) getteximage-formats failure: format: GL_SRGB8_ALPHA8_EXT, level 1 at pixel(369, 103) Expected (0.690273, 0.690273, 0.449981, 0.240292) Found (0.678431, 0.678431, 0.305882, 0.239216) Tolerance (0.031250, 0.031250, 0.031250, 0.031250) getteximage-formats failure: format: GL_SRGB8_ALPHA8_EXT, level 2 at pixel(421, 71) Expected (0.690273, 0.690273, 0.449981, 0.240292) Found (0.670588, 0.670588, 0.305882, 0.239216) Tolerance (0.031250, 0.031250, 0.031250, 0.031250) PIGLIT: {"result": "fail" }

6cf8708c is the first bad commit commit 6cf8708c Author: Kenneth Graunke kenneth@whitecape.org Date: Fri Aug 12 14:48:54 2016 -0700

meta: Always do GenerateMipmaps in linear colorspace.

When generating mipmaps for sRGB textures, force both decode and encode,
so the filtering is done in linear colorspace, regardless of settings.

Fixes a WebGL conformance test in Chrome:
https://www.khronos.org/registry/webgl/sdk/tests/conformance2/textures/misc/tex-srgb-mipmap.html?webglVersion=2

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97322
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>

:040000 040000 733e4c7b073125598497a608ebd397f141256506 55d86d5e6b408e71bb86f249941fd03d224934c7 M src bisect run success

Version: 13.0

Blocking

  • Bug 98471
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking