[GEN9+] 2-11% performance drop in GfxBench ALU2 & SynMark TexFilterTri from "i965/tex: Use blorp texture upload for all CCS_E textures"

Submitted by Eero Tamminen

Assigned to Jason Ekstrand @jekstrand

Description

While following change:

commit 157faa40 Author: Jason Ekstrand jason.ekstrand@intel.com AuthorDate: Wed May 31 17:53:34 2017 -0700 Commit: Kenneth Graunke kenneth@whitecape.org CommitDate: Thu Oct 12 19:58:40 2017 -0700

i965/tex: Use blorp texture upload for all CCS_E textures

This improves the FillTex benchmark in GLBench 2.7 by 30% on my Broxton.
On Ken's Broxton which only has single-channel ram, it improves by 210%.

v2 (Ken): Check mt->aux_usage == ISL_AUX_USAGE_CCS_E rather than using
          intel_miptree_is_lossless_compressed().

Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

improved GLB 2.7 Fill hugely and SynMark PSPom slightly on all GEN9+ SoC platforms, it also clearly regressed few tests on all GEN9+ platforms.

These regressions are (depending on platform):

3-5% in GfxBench v4 ALU2 onscreen & offscreen tests
2-6% in SynMark v7 TexFilterTri test

Version: git

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information