Mike Blumenkrantz authored Jul 15, 2022 and Marge Bot committed Jul 26, 2022

this will be useful for debugging
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <!17667>

Mike Blumenkrantz authored Jul 15, 2022 and Marge Bot committed Jul 26, 2022

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <!17667>

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!17709>

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!17709>

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!17709>

Mike Blumenkrantz authored Jul 19, 2022 and Marge Bot committed Jul 20, 2022

no functional changes, but now AUTO is no longer a mode that gets used
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <!17636>

Mike Blumenkrantz authored Jul 19, 2022 and Marge Bot committed Jul 20, 2022

this was useful for testing but is going to be less useful soon
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <!17636>

Timur Kristóf authored Jun 08, 2022 and Marge Bot committed Jun 21, 2022

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!16929>

Erik Faye-Lund authored Jun 14, 2022 and Marge Bot committed Jun 15, 2022

This requirement is for ARB_texture_buffer_object_rgb32, which obviously
needs the UNIFORM_TEXEL_BUFFER bit, not SAMPLED_IMAGE.

Fixes: c3d7de47 ("docs/zink: add GL 4.0 requirements")
Fixes: 6b38907b

 ("zink: fix feature requirement")
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!17024>

Mike Blumenkrantz authored Jun 10, 2022 and Marge Bot committed Jun 10, 2022

Part-of: <!16981>

Mike Blumenkrantz authored Jun 10, 2022 and Marge Bot committed Jun 10, 2022

Part-of: <!16981>

Mike Blumenkrantz authored Jun 10, 2022 and Marge Bot committed Jun 10, 2022

this is ARB_texture_buffer_object_rgb32, and both bits are needed

Part-of: <!16981>

Mike Blumenkrantz authored May 27, 2022 and Marge Bot committed May 31, 2022

this is not required by any version of GL, so don't pretend it's needed

cc: mesa-stable
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <!16758>

Mike Blumenkrantz authored May 27, 2022 and Marge Bot committed May 31, 2022

this is not a requirement for any version of GL, so don't pretend it's
a requirement

cc: mesa-stable
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <!16758>

Mike Blumenkrantz authored Apr 20, 2022 and Marge Bot committed May 18, 2022

this is great for debugging
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <mesa/mesa!16544>

Yonggang Luo authored Apr 19, 2022 and Marge Bot committed Apr 21, 2022

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <mesa/mesa!16026>

Yonggang Luo authored Apr 19, 2022 and Marge Bot committed Apr 21, 2022

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <!16026>

Mike Blumenkrantz authored Apr 12, 2022 and Marge Bot committed Apr 18, 2022

this allows for deleting tons of code
Acked-by: Adam Jackson <ajax@redhat.com>
Part-of: <!15904>

Mike Blumenkrantz authored Apr 12, 2022 and Marge Bot committed Apr 18, 2022

drivers should be able to support this, and it allows for deleting
a lot of untested code
Acked-by: Adam Jackson <ajax@redhat.com>
Part-of: <!15904>

Mike Blumenkrantz authored Mar 25, 2022 and Marge Bot committed Apr 18, 2022

this allows the removal of tons of awful code
Acked-by: Adam Jackson <ajax@redhat.com>
Part-of: <!15904>

Erik Faye-Lund authored Mar 09, 2022 and Marge Bot committed Mar 09, 2022

Turns out, this was not proper use of language!
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!15300>

Erik Faye-Lund authored Mar 09, 2022 and Marge Bot committed Mar 09, 2022

The multiViewport feature isn't required for GL 4.3, it's required for
GL 4.1. Technically speaking, we could have just dropped it because we
already list the maxViewports requirement. But it seems better to be
very clear here to me.

Fixes: 29f8f21b

 ("docs: document zink GL 4.3 requirements")
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!15300>

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <!12783>

We currently require VK_EXT_line_rasterization with *all* optional
features to render all kinds of lines required. Because some (if not
all) of these can be emulated, let's make the list explicit, so it's
easy to remove items as we implement emulation.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!11795>

We have decided to follow what's happening with #dri-devel for #zink as
well, so let's update our link there as well.

While we're at it, let's switch the link to an anonymous link, because
we're not referring to it anywhere, so it doesn't need to be named.
Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <!10917>

Fixing the fix, I guess I was a bit too quick last time ;)

Fixes: 0747fb54

 ("docs: fixup link to extension")
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <mesa/mesa!10478>

I mixed up the EXT and ARB version of the extensions; we actually do
require shaderStorageImageWriteWithoutFormat as well here.

Thanks to Ilia Mirkin for pointing this out.

It also seems I got really confused about what was required when writing
the docs, so let's fix that as well.

Fixes: 341332b2 ("zink: correct image cap checks")
Fixes: ecac7f3d

 ("docs: add missing zink-requirement")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!10463>

Part-of: <!10458>

We need this feature in order to enable OpenGL 4.2 on Zink.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <mesa/mesa!10456>

These two were quoted differently than the other limits in this
document. Let's fix that to be consistent.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!10455>

I accidentally missed the actual link-definition here, so let's add
that.

Fixes: ff007afc

 ("zink: document requirement of VK_EXT_custom_border_color")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!10455>

The claim that we require vulkan memory model's MakeAvailable and
MakeVisible semantics for image writes isn't accurate. This would be
required *if* we were already using the Vulkan memory model.

But we're using the GLSL450 memory model in those cases, which has no
such requirements.

This means that any problems on RADV due to the lack of these semantics
are RADV bugs, and should be fixed in RADV instead.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!10345>

Without this extension, we misrender when custom border colors are
used. Let's document this, and emit a warning when the extension is
missing.
Reviewed-by: Joshua Ashton <joshua@froggi.es>
Part-of: <!10316>

We're currently using uint arrays instead of uvec4 arrays for UBOs and
SSBOs, which requires scalarBlockLayout. Fixing this is a lot of work,
so let's just document it for now.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!10127>

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!9925>

While we should probably use this extension at some point, we don't
currently do. So let's remove it, so the code documents the status-quo
instead of some potential future direction.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!9925>

Zink does not require VK_KHR_get_physical_device_properties2; we have
fallback-code in place for when that is lacking.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!9925>

VkPhysicalDeviceFeatures::depthClamp isn't required until GL 3.2, where
we already list it. Remove the extra entry to avoid confusion.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!9925>

This cap depends on a device extension.

Fixes: b59d98ae

 ("zink: enable PIPE_CAP_TEXTURE_MIRROR_CLAMP_TO_EDGE")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!9803>

We check for this feature in zink_is_format_supported, so VK drivers
need to expose it to get BC textures working. Let's document the
reality.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <!9803>