- 07 Jul, 2022 33 commits
-
-
This turned out to be not a CTS bug but rather hardware bug around the cache handle BCn textures. It requires significant tracking to detect such cases, and it's likely not worth a workaround since reading a texture as both compressed and uncompressed in succession shall not be a realistic use case. Closes: mesa/mesa#6689 Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!17345>
-
It's easy to misuse glDrawElements and end up with an invalid indices offset. Since this can cause a hang, detect this case and skip the draw. Closes: mesa/mesa#6625 Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!16662>
-
Type casting may require specific alignment on some platforms; since the input data can be provided by the application we can't require any alignment. Switch to using memcpy like the write functions do, and drop the asserts. Closes: mesa/mesa#6493 Reviewed-by:
-
This fixes tests using imageLoad/imageStore on texture created using glEGLImageTargetTexture2DOES. Before this change, the format was guessed as GL_RGBA, which would be rejected by _mesa_get_shader_image_format. Reviewed-by:
Adam Jackson <ajax@redhat.com> Reviewed-by:
-
For images created from textures or renderbuffer, the internal format is known so store it. This will be used in the next commit to replaces guessing it. Reviewed-by:
-
Not had time to investiguate what is going is on but it's definitely a contributor to failures. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Acked-by: Caio Oliveira <caio.oliveira@intel.com> Part-of: <mesa/mesa!16104>
-
We can't unconditionally support separable shader objects on the host, so submit the property only if the shader is actually separable, the host knows about the property, and supports SSO. Without support for SSOs, the host can still compile and link the shaders, it needs to do more work on interface matching though. Signed-off-by:
Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!17344>
-
Most drivers don't care about the property, and virgl should only handle it if the host supports it. This is a partial revert of b6340305, i.e. we keep the definition of the property, but we don't set it only based on the shader info. Fixes: b6340305 tgsi: Add SEPARABLE_PROGRAM property Part-of: <mesa/mesa!17344>
-
multop + umul24 can only be used to implement 32-bit multiplies, so for a full 64-bit result we always need to lower. Reviewed-by:
Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <mesa/mesa!17372> -
We can produce slightly better code for these in the backend, so do that. For this we need to: 1. Fix our implementation of uadd_carry (which wasn't used) to return an integer instead of a boolean value. 2. Add an implementation of usub_borrow. Notice these are only used in Vulkan. In GL these instructions are always unconditionally lowered by the state tracker in GLSL IR so we never get to see them in the backend. Shader-db stats from a collection of Vulkan samples: total instructions in shared programs: 122351 -> 122345 (<.01%) instructions in affected programs: 196 -> 190 (-3.06%) helped: 2 HURT: 0 total uniforms in shared programs: 18670 -> 18672 (0.01%) uniforms in affected programs: 59 -> 61 (3.39%) helped: 0 HURT: 2 total max-temps in shared programs: 13145 -> 13147 (0.02%) max-temps in affected programs: 27 -> 29 (7.41%) helped: 0 HURT: 2 total inst-and-stalls in shared programs: 123052 -> 123046 (<.01%) inst-and-stalls in affected programs: 197 -> 191 (-3.05%) helped: 2 HURT: 0 Reviewed-by:
Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <mesa/mesa!17372> -
These opcodes where fixed to return an integer instead of a boolean value some time ago but the documentation for them was not updated and still talked about a boolean result. Fixes: b0d4ee52 ('nir/opcodes: Fix up uadd_carry and usub_borrow') Reviewed-by:
Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <mesa/mesa!17372> -
Lionel Landwerlin authored
The thread dispatch SEND instructions will dispatch new threads immediately even before the caller of the SEND instruction has reached EOT. So we really need to make sure all the memory writes are visible to other threads within the DSS before the SEND. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: -
Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Part-of: <mesa/mesa!17387>
-
Signed-off-by:
Dawn Han <dawnhan@google.com> Part-of: <mesa/mesa!16699>
-
Signed-off-by:
-
Signed-off-by:
-
Verified the pNext VkWriteDescriptorSet is not NULL on iub type Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Use SPDX to indicate the license. Update authors of lava_job_submitter.py Signed-off-by:
Guilherme Gallo <guilherme.gallo@collabora.com> Part-of: <mesa/mesa!16323>
-
Use FG to indicate foreground colors Signed-off-by:
-
In some jobs, such as https://gitlab.freedesktop.org/gallo/mesa/-/jobs/24904100 , the kmsg is interleaved with stderr/stdout in serial console, making it difficult to confidently find the log messages to detect when the DUT is booting, when the DUT is running etc. Luckily, LAVA sends redundant messages about their signals. We can use them to mitigate the chance of missing an interleaved message by being more open to different messages, using the regex on both `debug` and `target` LAVA log levels. Signed-off-by:
-
There are some leftovers in the jobs logs after the result log line. Only print until the init-stage2.sh output, to raise the chance to check for the test script results at the first glance in the Gitlab logs. Extra changes: - Add `hung` status for jobs considered hanging in the Gitlab - print them after the retry loop Signed-off-by:
-
It should be clear to the developer that the job was not successful in the first run. Signed-off-by:
-
This will serve to warn the user that those messages are processed differently, e.g. the kmsgs does not trigger heartbeats and maybe eventual targets of hint to retry the job immediately. Signed-off-by:
-
Remove debug messages from the output in order to unclutter the log a little more for the developers. Signed-off-by:
-
test_full_yaml_log is a test that will look for a LAVA log YAML file at `/tmp/log.yaml` and consume it as it was a realtime CI job. It is useful for debugging issues related with LAVA. Let's keep it skipped by default, to avoid introducing entire logs into the codebase. Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Currently, the submitter consider that every new log that comes from the DUT console is a signal that the device is healthy, but maybe that is not the case, since in some kernel hangs/failures, no output is presented except from some kernel messages. This commit bypass the heartbeat when the LogFollower detect a kernel message. Any log line that does follow the kmsg pattern will make the job labeled as healthy again. Signed-off-by:
-
Now LogFollower is used to deal with the LAVA logs. Moreover, this commit adds timeouts per Gitlab section, if a section takes longer than expected, cancel the job and retry again. Signed-off-by:
-
- Create LogFollower to capture LAVA log and process it adding some - GitlabSection and color treatment to it - Break logs further, make new gitlab sections between testcases - Implement LogFollower as ContextManager to deal with incomplete LAVA jobs. - Use template method to simplify gitlab log sections management - Fix sections timestamps Signed-off-by:
-
Gitlab has support for collapsible sections, so it would be good to create collapsed log sections for the LAVA setup logs. This way, the Mesa developers to see only the execution of the scripts, instead of LAVA messages clutter. Signed-off-by:
-
- 06 Jul, 2022 7 commits
-
-
It is optional and is needed only when a layer has physical device extensions that may be unknown to the loader. This simplifies the layer a bit, but more importantly, it works around a bug in the loader when there is another layer in the layer chain that wraps VkInstance. Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16307>
-
Dylan Baker authored
There's been several requests to push the release back a bit to allow more time in the 22.2 cycle, so we'll bump by two weeks. This adds an extra 22.1 release to the schedule as well, due to the move. Part-of: <mesa/mesa!17384>
-
Passes dEQP-VK.pipeline.*.shader_module_identifier.* Reviewed-by:
-
Reviewed-by:
-
Acked-by:
-
ETOOSPAMMY Reviewed-by:
Emma Anholt <emma@anholt.net> Reviewed-by:
Yusuf Khan <yusisamerican@gmail.com> Part-of: <!17362>
-
Return the capabilities reported by the host. No functional change in case the host virgl implementation doesn't implement it. Signed-off-by:
Corentin Noël <corentin.noel@collabora.com> Reviewed-by:
Italo Nicola <italonicola@collabora.com> Part-of: <!16401>
-
