Commits · 86b2b4eb768bcee6664790a66fc5508002e34424 · Mesa / mesa

23 Oct, 2020 40 commits

panfrost: Move nir_undef_to_zero to common util/ · 86b2b4eb

Alyssa Rosenzweig authored Oct 15, 2020



Will use for Bifrost as well.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

86b2b4eb

pan/bi: Pipe through tls_size · f0421099

Alyssa Rosenzweig authored Oct 14, 2020



So we have stack memory allocated.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

f0421099

pan/bi: Implement spilling · b43b1535

Alyssa Rosenzweig authored Oct 14, 2020



Now that all the helpers are in place, we can wire it up.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

b43b1535

pan/bi: Pack LOAD/STORE · e33b2976

Alyssa Rosenzweig authored Oct 14, 2020



LOAD is the same as LOAD_UNIFORM (same instruction, I need to
deduplicate the IR), STORE is basically the same as LOAD.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

e33b2976

pan/bi: Add bi_foreach_clause_in_block_safe helper · 74be83d8
Alyssa Rosenzweig authored Oct 14, 2020
```
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>
```
74be83d8

pan/bi: Factor out singleton construction from scheduler · 2ff54cac

Alyssa Rosenzweig authored Oct 14, 2020



We'll reuse the logic in spilling.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

2ff54cac

pan/bi: Implement bi_spill_register · 2d0f46a1

Alyssa Rosenzweig authored Oct 14, 2020



Given a node to spill, insert the appropriate loads and stores to spill
it.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

2d0f46a1

pan/bi: Add helpers for working with singletons · 82dbc4ea

Alyssa Rosenzweig authored Oct 14, 2020



Clauses with exactly one instruction (not canonical terminology to my
knowledge, but the notation is suggestive). Since these are isomorphic
to the instructions themselves, we want helpers to go between the forms.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

82dbc4ea

pan/bi: Add bi_rewrite_index_src_single helper · 1db83fc7

Alyssa Rosenzweig authored Oct 14, 2020



Ported from Midgard.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

1db83fc7

pan/bi: Add bi_fill · 9e915fd5

Alyssa Rosenzweig authored Oct 14, 2020



Likewise generates LOAD from tls.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

9e915fd5

pan/bi: Add bi_spill helper · 486a820b

Alyssa Rosenzweig authored Oct 14, 2020



Generates STORE to TLS.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

486a820b

pan/bi: Add spills/fills parameters · 171bf199

Alyssa Rosenzweig authored Oct 14, 2020



For future shader-db integration.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

171bf199

pan/bi: Implement bi_choose_spill_node · 7246dd88

Alyssa Rosenzweig authored Oct 14, 2020



Simplified from Midgard.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

7246dd88

pan/bi: Add no_spill flag to IR · ab9abc90

Alyssa Rosenzweig authored Oct 14, 2020



Will be used to prevent double spills.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

ab9abc90

pan/bi: Stub spilling · ad8a8499

Alyssa Rosenzweig authored Oct 14, 2020



Like Midgard.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

ad8a8499

pan/bi: Fix handling of small constants in bi_lookup_constant · 8477678c

Alyssa Rosenzweig authored Oct 14, 2020



Streamline the logic and the bug goes away.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

8477678c

pan/bi: Drop 64-bit constant support · 82a62a6f

Alyssa Rosenzweig authored Oct 14, 2020



We don't support 64-bit clauses and don't intend to (v6 only, v7 doesn't
support them) so this is irrelevant.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

82a62a6f

pan/mdg: Cleanup mir_rewrite_index_src_single · d2bfcba5

Alyssa Rosenzweig authored Oct 14, 2020



Use idiomatic iterator.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

d2bfcba5

panfrost: Drop panfrost_vt_emit_shared_memory · b19d9c86

Alyssa Rosenzweig authored Oct 14, 2020



Let's reuse the same routines across Midgard/Bifrost so we get proper
handling of spilling.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

b19d9c86

panfrost: Use canonical characterization of tls_size · e6152091
Alyssa Rosenzweig authored Oct 14, 2020
```
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>
```
e6152091

panfrost: Get rid of the non-native wallpering bits · a33827d3

Boris Brezillon authored Oct 18, 2020



Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

a33827d3

panfrost: Use native wallpapering on Bifrost · c89f659f

Boris Brezillon authored Oct 18, 2020



Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

c89f659f

panfrost: Add support for native wallpapering on Bifrost · edd98aac

Boris Brezillon authored Oct 18, 2020



Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

edd98aac

panfrost: Split panfrost_load_midg() · a677e34e

Boris Brezillon authored Oct 18, 2020



It makes it easier to read and will allow re-using common bits for
the bifrost reload logic.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

a677e34e

panfrost: Pass the texture payload through a panfrost_ptr · 8892c9cd

Boris Brezillon authored Oct 18, 2020



We want to be able to pass a payload allocated from the pool, so let's
change the function prototype to allow that.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

8892c9cd

panfrost: Rename gtransfer to transfer · 3f91d819

Alyssa Rosenzweig authored Oct 21, 2020



Now that panfrost_transfer is renamed to panfrost_ptr.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

3f91d819

panfrost: Rename panfrost_transfer to panfrost_ptr · 1b3b289c

Boris Brezillon authored Oct 18, 2020



And use it in panfrost_bo to store a GPU/CPU pointer tuple.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

1b3b289c

panfrost: Use real name for attribute's unknown field · bf3cd283

Boris Brezillon authored Oct 18, 2020



Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

bf3cd283

panfrost: Build blit shaders on Bifrost too · 6b68c821

Boris Brezillon authored Oct 17, 2020



Now that the compiler has been patched to support all the instructions
used by blit shaders we can compile them unconditionally.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

6b68c821

panfrost: Make {midgard,bifrost}_compile_shader_nir() return a program object · 69c864b0

Boris Brezillon authored Oct 17, 2020

Letting the caller zero-initialize the program object is error prone,
not to mention that resources attached to the program might not be freed
by the caller. Let's simplify that by letting the compiler allocate the
panfrost_program object. Those objects should be freed with ralloc_free().

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

69c864b0

pan/bi: Add basic support for txf_ms · b83c2936

Boris Brezillon authored Oct 17, 2020



We currently don't support txf_ms instructions specifying a texel offset
src.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

b83c2936

pan/bi: Support the case where TEXC needs 0 or 1 staging reg · d33c8afe

Boris Brezillon authored Oct 17, 2020



No need to add a COMBINE instruction if TEXC only needs zero or one
staging reg.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

d33c8afe

pan/bi: Add support for load_sample_id · 4aff27a6

Boris Brezillon authored Oct 17, 2020



Sample ID is preloaded in r61.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

4aff27a6

pan/bi: Print blend descriptor source properly · e2d61567

Boris Brezillon authored Oct 17, 2020



Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

e2d61567

pan/bi: Make sure we don't print special index as a register · 74c15801

Boris Brezillon authored Oct 17, 2020



index can have both a SPECIAL flag and PAN_IS_REG (bit 0) set, but we
shouln't treat the index as a register in that case. Let's bail out
early in bi_print_dest_index() when we're passed a special index
that's not a register.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

74c15801

panfrost: Replace unkown renderer state fields by their real names · a194dcc8

Boris Brezillon authored Oct 17, 2020



Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

a194dcc8

panfrost: Add specialized preload descriptors · 7486b5d9

Boris Brezillon authored Oct 17, 2020



It's just easier to identify the different layouts this way.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

7486b5d9

panfrost: Add the bifrost tiler internal state field · d769697f

Boris Brezillon authored Oct 17, 2020



The internal state is updated every time a tiler job is executed, and
pandecode complains that unused bits are not zero-ed when that happens.
Define the internal state (not meant to be set by the driver) to remove
those spurious errors.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

d769697f

panfrost: Fix tiler job injection · 2f1947b3

Boris Brezillon authored Oct 17, 2020



When injecting a tiler job, we shouln't make it depend on the last tiler
job, but instead make the first tiler job depend on it.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

2f1947b3

panfrost: Adjust the renderer state definition · 519643bb

Boris Brezillon authored Oct 13, 2020



Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <!7206>

519643bb