1. 07 Aug, 2018 12 commits
  2. 06 Aug, 2018 12 commits
  3. 04 Aug, 2018 16 commits
    • Karol Herbst's avatar
      nvc0/ir: return 0 in imageLoad on incomplete textures · c3325097
      Karol Herbst authored
      We already guarded all OP_SULDP against out of bound accesses, but we
      ended up just reusing whatever value was stored in the dest registers.
      
      Fixes CTS test shader_image_load_store.incomplete_textures
      
      v2: fix for loads not ending up with predicates (bindless_texture)
      v3: fix replacing the def
      
      Cc: <mesa-stable@lists.freedesktop.org>
      Reviewed-by: Ilia Mirkin's avatarIlia Mirkin <imirkin@alum.mit.edu>
      Signed-off-by: Karol Herbst's avatarKarol Herbst <kherbst@redhat.com>
      c3325097
    • Karol Herbst's avatar
      gm200/ir: optimize rcp(sqrt) to rsq · 0ca046d7
      Karol Herbst authored
      mitigates hurt shaders after adding sqrt:
      total instructions in shared programs : 5456166 -> 5454825 (-0.02%)
      total gprs used in shared programs    : 647522 -> 647551 (0.00%)
      total shared used in shared programs  : 389120 -> 389120 (0.00%)
      total local used in shared programs   : 21064 -> 21064 (0.00%)
      total bytes used in shared programs   : 58288696 -> 58274448 (-0.02%)
      
                      local     shared        gpr       inst      bytes
          helped           0           0           0         516         516
            hurt           0           0          27           2           2
      Reviewed-by: Ilia Mirkin's avatarIlia Mirkin <imirkin@alum.mit.edu>
      Signed-off-by: Karol Herbst's avatarKarol Herbst <kherbst@redhat.com>
      0ca046d7
    • Karol Herbst's avatar
      gm200/ir: add native OP_SQRT support · 6f98a306
      Karol Herbst authored
      ./GpuTest /test=pixmark_piano 1024x640 30sec:
      301 -> 327 points
      
      shader-db:
      total instructions in shared programs : 5472103 -> 5456166 (-0.29%)
      total gprs used in shared programs    : 647530 -> 647522 (-0.00%)
      total shared used in shared programs  : 389120 -> 389120 (0.00%)
      total local used in shared programs   : 21064 -> 21064 (0.00%)
      total bytes used in shared programs   : 58459304 -> 58288696 (-0.29%)
      
                      local     shared        gpr       inst      bytes
          helped           0           0          27        8281        8281
            hurt           0           0          21         431         431
      
      v2: use NVISA_GM200_CHIPSET
      Reviewed-by: Ilia Mirkin's avatarIlia Mirkin <imirkin@alum.mit.edu>
      Signed-off-by: Karol Herbst's avatarKarol Herbst <kherbst@redhat.com>
      6f98a306
    • Lionel Landwerlin's avatar
      intel: tools: simplify meson build · 4334196a
      Lionel Landwerlin authored
      Remove the if tools condition and just put it through the install:
      parameter.
      Signed-off-by: Lionel Landwerlin's avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      4334196a
    • Lionel Landwerlin's avatar
      intel: aubinator: simplify decoding · 87a3c977
      Lionel Landwerlin authored
      Since we don't support streaming an aub file, we can drop the decoding
      status enum.
      
      v2: include stdbool (Eric)
      Signed-off-by: Lionel Landwerlin's avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      Reviewed-by: Eric Engestrom's avatarEric Engestrom <eric.engestrom@intel.com>
      87a3c977
    • Lionel Landwerlin's avatar
    • Lionel Landwerlin's avatar
    • Lionel Landwerlin's avatar
    • Lionel Landwerlin's avatar
      intel: aubinator: fix read the context/ring · 35955afa
      Lionel Landwerlin authored
      Up to now we've been lucky that the buffer returned was always exactly
      at the address we requested.
      
      Fixes: 144b40db ("intel: aubinator: drop the 1Tb GTT mapping")
      Signed-off-by: Lionel Landwerlin's avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      Reviewed-by: Rafael Antognolli's avatarRafael Antognolli <rafael.antognolli@intel.com>
      35955afa
    • Ian Romanick's avatar
      nir: Transform expressions of b2f(a) and b2f(b) to a == b · 3b07d28f
      Ian Romanick authored
      All Gen7+ platforms had similar results. (Skylake shown)
      total instructions in shared programs: 14276886 -> 14276838 (<.01%)
      instructions in affected programs: 312 -> 264 (-15.38%)
      helped: 2
      HURT: 0
      
      total cycles in shared programs: 532578395 -> 532570985 (<.01%)
      cycles in affected programs: 682562 -> 675152 (-1.09%)
      helped: 374
      HURT: 4
      helped stats (abs) min: 2 max: 200 x̄: 20.39 x̃: 18
      helped stats (rel) min: 0.07% max: 11.64% x̄: 1.25% x̃: 1.28%
      HURT stats (abs)   min: 2 max: 114 x̄: 53.50 x̃: 49
      HURT stats (rel)   min: 0.06% max: 11.70% x̄: 5.02% x̃: 4.15%
      95% mean confidence interval for cycles value: -21.30 -17.91
      95% mean confidence interval for cycles %-change: -1.30% -1.06%
      Cycles are helped.
      
      Sandy Bridge
      total instructions in shared programs: 10488123 -> 10488075 (<.01%)
      instructions in affected programs: 336 -> 288 (-14.29%)
      helped: 2
      HURT: 0
      
      total cycles in shared programs: 150260379 -> 150260439 (<.01%)
      cycles in affected programs: 4726 -> 4786 (1.27%)
      helped: 0
      HURT: 2
      
      No changes on Iron Lake or GM45.
      Signed-off-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Reviewed-by: Thomas Helland's avatarThomas Helland <thomashelland90@gmail.com>
      3b07d28f
    • Ian Romanick's avatar
      nir: Transform expressions of b2f(a) and b2f(b) to a ^^ b · c658b6c4
      Ian Romanick authored
      All Gen platforms had pretty similar results. (Skylake shown)
      total instructions in shared programs: 14276892 -> 14276886 (<.01%)
      instructions in affected programs: 484 -> 478 (-1.24%)
      helped: 2
      HURT: 0
      
      total cycles in shared programs: 532578397 -> 532578395 (<.01%)
      cycles in affected programs: 3522 -> 3520 (-0.06%)
      helped: 1
      HURT: 0
      Signed-off-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Reviewed-by: Thomas Helland's avatarThomas Helland <thomashelland90@gmail.com>
      c658b6c4
    • Ian Romanick's avatar
      nir: Transform expressions of b2f(a) and b2f(b) to !(a && b) · 3aca80aa
      Ian Romanick authored
      All Gen platforms had pretty similar results. (Skylake shown)
      total cycles in shared programs: 532578400 -> 532578397 (<.01%)
      cycles in affected programs: 2784 -> 2781 (-0.11%)
      helped: 1
      HURT: 1
      helped stats (abs) min: 4 max: 4 x̄: 4.00 x̃: 4
      helped stats (rel) min: 0.26% max: 0.26% x̄: 0.26% x̃: 0.26%
      HURT stats (abs)   min: 1 max: 1 x̄: 1.00 x̃: 1
      HURT stats (rel)   min: 0.08% max: 0.08% x̄: 0.08% x̃: 0.08%
      
      v2: s/fmax/fmin/.  Noticed by Thomas Helland.
      Signed-off-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Reviewed-by: Thomas Helland's avatarThomas Helland <thomashelland90@gmail.com>
      3aca80aa
    • Ian Romanick's avatar
      nir: Transform expressions of b2f(a) and b2f(b) to a && b · 1713c971
      Ian Romanick authored
      No changes on any Gen platform.
      
      v2: s/fmax/fmin/.  Noticed by Thomas Helland.
      Signed-off-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Reviewed-by: Thomas Helland's avatarThomas Helland <thomashelland90@gmail.com>
      1713c971
    • Ian Romanick's avatar
      nir: Transform expressions of b2f(a) and b2f(b) to !(a || b) · 4425f478
      Ian Romanick authored
      All Gen6+ platforms had similar results. (Skylake shown)
      total instructions in shared programs: 14276961 -> 14276892 (<.01%)
      instructions in affected programs: 3215 -> 3146 (-2.15%)
      helped: 28
      HURT: 0
      helped stats (abs) min: 1 max: 6 x̄: 2.46 x̃: 2
      helped stats (rel) min: 0.47% max: 9.52% x̄: 4.34% x̃: 1.92%
      95% mean confidence interval for instructions value: -2.87 -2.06
      95% mean confidence interval for instructions %-change: -5.73% -2.95%
      Instructions are helped.
      
      total cycles in shared programs: 532577068 -> 532578400 (<.01%)
      cycles in affected programs: 121864 -> 123196 (1.09%)
      helped: 35
      HURT: 30
      helped stats (abs) min: 2 max: 268 x̄: 42.34 x̃: 22
      helped stats (rel) min: 0.12% max: 12.14% x̄: 3.22% x̃: 1.86%
      HURT stats (abs)   min: 2 max: 246 x̄: 93.80 x̃: 36
      HURT stats (rel)   min: 0.09% max: 13.63% x̄: 4.47% x̃: 2.58%
      95% mean confidence interval for cycles value: -5.02 46.01
      95% mean confidence interval for cycles %-change: -0.99% 1.65%
      Inconclusive result (value mean confidence interval includes 0).
      
      Iron Lake and GM45 had similar results. (Iron Lake shown)
      total instructions in shared programs: 7781299 -> 7781342 (<.01%)
      instructions in affected programs: 22300 -> 22343 (0.19%)
      helped: 13
      HURT: 40
      helped stats (abs) min: 2 max: 3 x̄: 2.85 x̃: 3
      helped stats (rel) min: 1.15% max: 7.69% x̄: 3.72% x̃: 3.33%
      HURT stats (abs)   min: 2 max: 2 x̄: 2.00 x̃: 2
      HURT stats (rel)   min: 0.26% max: 1.30% x̄: 0.47% x̃: 0.43%
      95% mean confidence interval for instructions value: 0.23 1.39
      95% mean confidence interval for instructions %-change: -1.18% 0.07%
      Inconclusive result (%-change mean confidence interval includes 0).
      
      total cycles in shared programs: 177878928 -> 177879332 (<.01%)
      cycles in affected programs: 383298 -> 383702 (0.11%)
      helped: 7
      HURT: 43
      helped stats (abs) min: 2 max: 18 x̄: 10.00 x̃: 10
      helped stats (rel) min: 0.17% max: 4.81% x̄: 2.62% x̃: 3.40%
      HURT stats (abs)   min: 2 max: 38 x̄: 11.02 x̃: 12
      HURT stats (rel)   min: 0.08% max: 1.54% x̄: 0.25% x̃: 0.09%
      95% mean confidence interval for cycles value: 5.21 10.95
      95% mean confidence interval for cycles %-change: -0.51% 0.21%
      Inconclusive result (%-change mean confidence interval includes 0).
      
      v2: s/fmin/fmax/.  Noticed by Thomas Helland.
      Signed-off-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Reviewed-by: Thomas Helland's avatarThomas Helland <thomashelland90@gmail.com>
      4425f478
    • Ian Romanick's avatar
      nir: Transform -fabs(a) >= 0 to a == 0 · 6b3670ae
      Ian Romanick authored
      All Gen platforms had pretty similar results. (Skylake shown)
      total instructions in shared programs: 14276964 -> 14276961 (<.01%)
      instructions in affected programs: 411 -> 408 (-0.73%)
      helped: 3
      HURT: 0
      helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1
      helped stats (rel) min: 0.47% max: 1.96% x̄: 1.04% x̃: 0.68%
      
      total cycles in shared programs: 532577062 -> 532577068 (<.01%)
      cycles in affected programs: 1093 -> 1099 (0.55%)
      helped: 1
      HURT: 1
      helped stats (abs) min: 16 max: 16 x̄: 16.00 x̃: 16
      helped stats (rel) min: 7.77% max: 7.77% x̄: 7.77% x̃: 7.77%
      HURT stats (abs)   min: 22 max: 22 x̄: 22.00 x̃: 22
      HURT stats (rel)   min: 2.48% max: 2.48% x̄: 2.48% x̃: 2.48%
      Signed-off-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Reviewed-by: Thomas Helland's avatarThomas Helland <thomashelland90@gmail.com>
      6b3670ae
    • Ian Romanick's avatar
      nir: Transform expressions of b2f(a) and b2f(b) to a || b · 46e7c340
      Ian Romanick authored
      All Gen6+ platforms had pretty similar results. (Skylake shown)
      total instructions in shared programs: 14277184 -> 14276964 (<.01%)
      instructions in affected programs: 10082 -> 9862 (-2.18%)
      helped: 37
      HURT: 1
      helped stats (abs) min: 1 max: 30 x̄: 5.97 x̃: 4
      helped stats (rel) min: 0.14% max: 16.00% x̄: 5.23% x̃: 2.04%
      HURT stats (abs)   min: 1 max: 1 x̄: 1.00 x̃: 1
      HURT stats (rel)   min: 0.70% max: 0.70% x̄: 0.70% x̃: 0.70%
      95% mean confidence interval for instructions value: -7.87 -3.71
      95% mean confidence interval for instructions %-change: -6.98% -3.16%
      Instructions are helped.
      
      total cycles in shared programs: 532577990 -> 532577062 (<.01%)
      cycles in affected programs: 170959 -> 170031 (-0.54%)
      helped: 33
      HURT: 9
      helped stats (abs) min: 2 max: 120 x̄: 30.91 x̃: 30
      helped stats (rel) min: 0.02% max: 7.65% x̄: 2.66% x̃: 1.13%
      HURT stats (abs)   min: 2 max: 24 x̄: 10.22 x̃: 8
      HURT stats (rel)   min: 0.09% max: 1.79% x̄: 0.61% x̃: 0.22%
      95% mean confidence interval for cycles value: -31.23 -12.96
      95% mean confidence interval for cycles %-change: -2.90% -1.02%
      Cycles are helped.
      
      Iron Lake and GM45 had similar results. (Iron Lake shown)
      total instructions in shared programs: 7781539 -> 7781301 (<.01%)
      instructions in affected programs: 10169 -> 9931 (-2.34%)
      helped: 32
      HURT: 0
      helped stats (abs) min: 2 max: 20 x̄: 7.44 x̃: 6
      helped stats (rel) min: 0.47% max: 17.02% x̄: 4.03% x̃: 1.88%
      95% mean confidence interval for instructions value: -9.53 -5.34
      95% mean confidence interval for instructions %-change: -5.94% -2.12%
      Instructions are helped.
      
      total cycles in shared programs: 177878590 -> 177878932 (<.01%)
      cycles in affected programs: 78706 -> 79048 (0.43%)
      helped: 7
      HURT: 21
      helped stats (abs) min: 6 max: 34 x̄: 24.57 x̃: 28
      helped stats (rel) min: 0.15% max: 8.33% x̄: 4.66% x̃: 6.37%
      HURT stats (abs)   min: 2 max: 86 x̄: 24.48 x̃: 22
      HURT stats (rel)   min: 0.01% max: 4.28% x̄: 1.21% x̃: 0.70%
      95% mean confidence interval for cycles value: 0.30 24.13
      95% mean confidence interval for cycles %-change: -1.52% 1.01%
      Inconclusive result (%-change mean confidence interval includes 0).
      
      v2: s/fmin/fmax/.  Noticed by Thomas Helland.
      Signed-off-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Reviewed-by: Thomas Helland's avatarThomas Helland <thomashelland90@gmail.com>
      46e7c340