 07 Aug, 2018 12 commits


Emil Velikov authored
With version v1.15 the "code" option was deprecated in favour of "privatecode" or "publiccode". Before the interface symbol generated was exported (which is a bad idea since it's internal implementation detail) and others may misuse it. That was the case with libva approx. 1 year ago. Since then libva was fixed, so we can finally hide it by using "privatecode" Inspired by similar xserver patch by Adam Jackson. Signedoffby: Emil Velikov <emil.velikov@collabora.com> Reviewedby: Dylan Baker <dylan@pnwbakers.com> Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Emil Velikov authored
With version v1.15 the "code" option was deprecated in favour of "privatecode" or "publiccode". Before the interface symbol generated was exported (which is a bad idea since it's internal implementation detail) and others may misuse it. That was the case with libva approx. 1 year ago. Since then libva was fixed, so we can finally hide it by using "privatecode" Inspired by similar xserver patch by Adam Jackson. Signedoffby: Emil Velikov <emil.velikov@collabora.com> Reviewedby: Dylan Baker <dylan@pnwbakers.com> Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Emil Velikov authored
Helps when the native waylandscanner is located outside of PATH. Inspired by the xserver code ;) Signedoffby: Emil Velikov <emil.velikov@collabora.com> Reviewedby: Dylan Baker <dylan@pnwbakers.com> Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Emil Velikov authored
With earlier rework the user and provider of the symbol are within the same binary. Thus there's no point in exporting the function. Spotted while reviewing patch from Chuck, that nearly added another unneeded PUBLIC function. Cc: Chuck Atkins <chuck.atkins@kitware.com> Cc: Tim Rowley <timothy.o.rowley@intel.com> Fixes: f50aa214 "(swr: build driver proper separate from rasterizer") Signedoffby: Emil Velikov <emil.velikov@collabora.com> Testedby: Chuck Atkins <chuck.atkins@kitware.com> ReviewedBy: George Kyriazis <george.kyriazis@intel.com<mailto:george.kyriazis@intel.com>> Testedby: Chuck Atkins <chuck.atkins@kitware.com<mailto:chuck.atkins@kitware.com>>

Eric Engestrom authored
Fixes: f7d42ee7 "include: update GL & GLES headers (v2)" Signedoffby: Eric Engestrom <eric.engestrom@intel.com> Reviewedby: Emil Velikov <emil.velikov@collabora.com>

Eric Engestrom authored
Signedoffby: Eric Engestrom <eric.engestrom@intel.com> Reviewedby: Tapani Pälli <tapani.palli@intel.com>

Eric Engestrom authored
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107511 Fixes: f7d42ee7 "include: update GL & GLES headers (v2)" Signedoffby: Eric Engestrom <eric.engestrom@intel.com> Testedby: Brad King <brad.king@kitware.com> Reviewedby: Emil Velikov <emil.velikov@collabora.com>

Lionel Landwerlin authored
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107487 Fixes: 4334196aw ("intel: tools: simplify meson build") Signedoffby: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Erik FayeLund authored
This just makes sure we're currently uptodate with what virglrenderer has. Signedoffby: Erik FayeLund <erik.fayelund@collabora.com> Ackedby: Dave Airlie <airlied@redhat.com>

Erik FayeLund authored
This matches what this field is called in virglrenderer's copy of this. This reduces the diff between the two different versions of virgl_hw.h, and should make it easier to upgrade the file in the future. Signedoffby: Erik FayeLund <erik.fayelund@collabora.com> Ackedby: Dave Airlie <airlied@redhat.com>

Eric Anholt authored
Fixes: bd192556 ("vc4: Convert the driver to emitting the shader record using pack macros.")

Eric Anholt authored
Noticed when trying to run current Mesa on rpi's downstream kernel. Fixes: b0acc3a5 ("broadcom/vc4: Native fence fd support")

 06 Aug, 2018 12 commits


Eric Anholt authored
This is needed to ensure that we don't get blocked waiting for VPM space with bin/render overlapping. Cc: "18.2" <mesastable@lists.freedesktop.org>

Eric Anholt authored
VC5 isn't a useful name any more, just stick to v3d.

Eric Anholt authored
Fixes bad rendering when forcing 2 spills in glxgears. Cc: "18.2" <mesastable@lists.freedesktop.org>

Eric Anholt authored
Found when debugging register spilling  we would try to spill the dest of a STVPMV, inserting spill code after entering the last segment. In fact, we were likely to to choose to do this, given that the STVPMV "dest" temp was never read from, making it cheap to spill. Cc: "18.2" <mesastable@lists.freedesktop.org>

Eric Anholt authored
The simulator complained that we had write responses outstanding at shader end. It seems that a TMU read does not guarantee that previous TMU writes by the thread have completed, which surprised me. Cc: "18.2" <mesastable@lists.freedesktop.org>

Eric Anholt authored
Found while forcing some spilling, which creates a lot of short tmua>thrsw>ldtmu sequences. Cc: "18.2" <mesastable@lists.freedesktop.org>

Eric Anholt authored
This is useful for periodically testing out register spilling to see how it goes on simple shaders, rather than only failing on insanely complicated ones.

chadversary authored
In commit cf54bd5e, dri_sw_winsys.c began using <sys/shm.h> to support the new functions putImageShm, getImageShm in DRI_SWRastLoader. But Android began supporting System V shared memory only in Oreo. Nougat has no shm headers. Fix the build by ifdef'ing out the shm code on Nougat. Fixes: cf54bd5e "drisw: use shared memory when possible" Reviewedby: Dave Airlie <airlied@redhat.com> Cc: MarcAndré Lureau <marcandre.lureau@gmail.com>

Ian Romanick authored
Signedoffby: Ian Romanick <ian.d.romanick@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107483 Fixes: 3d6900d7 ("glapi: define AMD_framebuffer_multisample_advanced and add its functions") Reviewedby: Marek Olšák <marek.olsak@amd.com> Cc: Vinson Lee <vlee@freedesktop.org>

Ian Romanick authored
The GL_AMD_framebuffer_multisample_advanced spec says: OpenGL ES dependencies: Requires OpenGL ES 3.0. Signedoffby: Ian Romanick <ian.d.romanick@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107483 Fixes: 3d6900d7 ("glapi: define AMD_framebuffer_multisample_advanced and add its functions") Reviewedby: Marek Olšák <marek.olsak@amd.com> Cc: Vinson Lee <vlee@freedesktop.org>

Gert Wollny authored
os.path.exists doesn't return True for stale symlinks, but they are in the way later, when a link/file with the same name is to be created. For instance it is conceivable that the pointed to file is replaced by a file with a new name, and then the symlink is dead. To handle this check specifically for all existing symlinks to be removed. (This bugged me for some time with a link libXvMCr600.so always being in the way of installing this file) v2: use only os.lexist and replace all instances of os.exist (Dylan Baker) v3: handle directory check correctly (Eric Engestrom) Fixes: f7f1b30f ("meson: extend install_megadrivers script to handle symmlinking") Reviewedby: Eric Engestrom <eric.engestrom@intel.com>(v2 minus dir check) Reviewedby: Dylan Baker <dylan@pnwbakers.com> Signedoffby: Gert Wollny <gert.wollny@collabora.com>

Tapani Pälli authored
This change helps with some of the dEQPVK.wsi.android.* tests that try to create swapchain with using such formats. Signedoffby: Tapani Pälli <tapani.palli@intel.com> Reviewedby: Chad Versace <chadversary@chromium.org>

 04 Aug, 2018 16 commits


Karol Herbst authored
We already guarded all OP_SULDP against out of bound accesses, but we ended up just reusing whatever value was stored in the dest registers. Fixes CTS test shader_image_load_store.incomplete_textures v2: fix for loads not ending up with predicates (bindless_texture) v3: fix replacing the def Cc: <mesastable@lists.freedesktop.org> Reviewedby: Ilia Mirkin <imirkin@alum.mit.edu> Signedoffby: Karol Herbst <kherbst@redhat.com>

Karol Herbst authored
mitigates hurt shaders after adding sqrt: total instructions in shared programs : 5456166 > 5454825 (0.02%) total gprs used in shared programs : 647522 > 647551 (0.00%) total shared used in shared programs : 389120 > 389120 (0.00%) total local used in shared programs : 21064 > 21064 (0.00%) total bytes used in shared programs : 58288696 > 58274448 (0.02%) local shared gpr inst bytes helped 0 0 0 516 516 hurt 0 0 27 2 2 Reviewedby: Ilia Mirkin <imirkin@alum.mit.edu> Signedoffby: Karol Herbst <kherbst@redhat.com>

Karol Herbst authored
./GpuTest /test=pixmark_piano 1024x640 30sec: 301 > 327 points shaderdb: total instructions in shared programs : 5472103 > 5456166 (0.29%) total gprs used in shared programs : 647530 > 647522 (0.00%) total shared used in shared programs : 389120 > 389120 (0.00%) total local used in shared programs : 21064 > 21064 (0.00%) total bytes used in shared programs : 58459304 > 58288696 (0.29%) local shared gpr inst bytes helped 0 0 27 8281 8281 hurt 0 0 21 431 431 v2: use NVISA_GM200_CHIPSET Reviewedby: Ilia Mirkin <imirkin@alum.mit.edu> Signedoffby: Karol Herbst <kherbst@redhat.com>

Lionel Landwerlin authored
Remove the if tools condition and just put it through the install: parameter. Signedoffby: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Lionel Landwerlin authored
Since we don't support streaming an aub file, we can drop the decoding status enum. v2: include stdbool (Eric) Signedoffby: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Lionel Landwerlin authored
Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Lionel Landwerlin authored
Signedoffby: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Lionel Landwerlin authored
Signedoffby: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Lionel Landwerlin authored
Up to now we've been lucky that the buffer returned was always exactly at the address we requested. Fixes: 144b40db ("intel: aubinator: drop the 1Tb GTT mapping") Signedoffby: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewedby: Rafael Antognolli <rafael.antognolli@intel.com>

Ian Romanick authored
All Gen7+ platforms had similar results. (Skylake shown) total instructions in shared programs: 14276886 > 14276838 (<.01%) instructions in affected programs: 312 > 264 (15.38%) helped: 2 HURT: 0 total cycles in shared programs: 532578395 > 532570985 (<.01%) cycles in affected programs: 682562 > 675152 (1.09%) helped: 374 HURT: 4 helped stats (abs) min: 2 max: 200 x̄: 20.39 x̃: 18 helped stats (rel) min: 0.07% max: 11.64% x̄: 1.25% x̃: 1.28% HURT stats (abs) min: 2 max: 114 x̄: 53.50 x̃: 49 HURT stats (rel) min: 0.06% max: 11.70% x̄: 5.02% x̃: 4.15% 95% mean confidence interval for cycles value: 21.30 17.91 95% mean confidence interval for cycles %change: 1.30% 1.06% Cycles are helped. Sandy Bridge total instructions in shared programs: 10488123 > 10488075 (<.01%) instructions in affected programs: 336 > 288 (14.29%) helped: 2 HURT: 0 total cycles in shared programs: 150260379 > 150260439 (<.01%) cycles in affected programs: 4726 > 4786 (1.27%) helped: 0 HURT: 2 No changes on Iron Lake or GM45. Signedoffby: Ian Romanick <ian.d.romanick@intel.com> Reviewedby: Thomas Helland <thomashelland90@gmail.com>

Ian Romanick authored
All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14276892 > 14276886 (<.01%) instructions in affected programs: 484 > 478 (1.24%) helped: 2 HURT: 0 total cycles in shared programs: 532578397 > 532578395 (<.01%) cycles in affected programs: 3522 > 3520 (0.06%) helped: 1 HURT: 0 Signedoffby: Ian Romanick <ian.d.romanick@intel.com> Reviewedby: Thomas Helland <thomashelland90@gmail.com>

Ian Romanick authored
All Gen platforms had pretty similar results. (Skylake shown) total cycles in shared programs: 532578400 > 532578397 (<.01%) cycles in affected programs: 2784 > 2781 (0.11%) helped: 1 HURT: 1 helped stats (abs) min: 4 max: 4 x̄: 4.00 x̃: 4 helped stats (rel) min: 0.26% max: 0.26% x̄: 0.26% x̃: 0.26% HURT stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 HURT stats (rel) min: 0.08% max: 0.08% x̄: 0.08% x̃: 0.08% v2: s/fmax/fmin/. Noticed by Thomas Helland. Signedoffby: Ian Romanick <ian.d.romanick@intel.com> Reviewedby: Thomas Helland <thomashelland90@gmail.com>

Ian Romanick authored
No changes on any Gen platform. v2: s/fmax/fmin/. Noticed by Thomas Helland. Signedoffby: Ian Romanick <ian.d.romanick@intel.com> Reviewedby: Thomas Helland <thomashelland90@gmail.com>

Ian Romanick authored
All Gen6+ platforms had similar results. (Skylake shown) total instructions in shared programs: 14276961 > 14276892 (<.01%) instructions in affected programs: 3215 > 3146 (2.15%) helped: 28 HURT: 0 helped stats (abs) min: 1 max: 6 x̄: 2.46 x̃: 2 helped stats (rel) min: 0.47% max: 9.52% x̄: 4.34% x̃: 1.92% 95% mean confidence interval for instructions value: 2.87 2.06 95% mean confidence interval for instructions %change: 5.73% 2.95% Instructions are helped. total cycles in shared programs: 532577068 > 532578400 (<.01%) cycles in affected programs: 121864 > 123196 (1.09%) helped: 35 HURT: 30 helped stats (abs) min: 2 max: 268 x̄: 42.34 x̃: 22 helped stats (rel) min: 0.12% max: 12.14% x̄: 3.22% x̃: 1.86% HURT stats (abs) min: 2 max: 246 x̄: 93.80 x̃: 36 HURT stats (rel) min: 0.09% max: 13.63% x̄: 4.47% x̃: 2.58% 95% mean confidence interval for cycles value: 5.02 46.01 95% mean confidence interval for cycles %change: 0.99% 1.65% Inconclusive result (value mean confidence interval includes 0). Iron Lake and GM45 had similar results. (Iron Lake shown) total instructions in shared programs: 7781299 > 7781342 (<.01%) instructions in affected programs: 22300 > 22343 (0.19%) helped: 13 HURT: 40 helped stats (abs) min: 2 max: 3 x̄: 2.85 x̃: 3 helped stats (rel) min: 1.15% max: 7.69% x̄: 3.72% x̃: 3.33% HURT stats (abs) min: 2 max: 2 x̄: 2.00 x̃: 2 HURT stats (rel) min: 0.26% max: 1.30% x̄: 0.47% x̃: 0.43% 95% mean confidence interval for instructions value: 0.23 1.39 95% mean confidence interval for instructions %change: 1.18% 0.07% Inconclusive result (%change mean confidence interval includes 0). total cycles in shared programs: 177878928 > 177879332 (<.01%) cycles in affected programs: 383298 > 383702 (0.11%) helped: 7 HURT: 43 helped stats (abs) min: 2 max: 18 x̄: 10.00 x̃: 10 helped stats (rel) min: 0.17% max: 4.81% x̄: 2.62% x̃: 3.40% HURT stats (abs) min: 2 max: 38 x̄: 11.02 x̃: 12 HURT stats (rel) min: 0.08% max: 1.54% x̄: 0.25% x̃: 0.09% 95% mean confidence interval for cycles value: 5.21 10.95 95% mean confidence interval for cycles %change: 0.51% 0.21% Inconclusive result (%change mean confidence interval includes 0). v2: s/fmin/fmax/. Noticed by Thomas Helland. Signedoffby: Ian Romanick <ian.d.romanick@intel.com> Reviewedby: Thomas Helland <thomashelland90@gmail.com>

Ian Romanick authored
All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14276964 > 14276961 (<.01%) instructions in affected programs: 411 > 408 (0.73%) helped: 3 HURT: 0 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.47% max: 1.96% x̄: 1.04% x̃: 0.68% total cycles in shared programs: 532577062 > 532577068 (<.01%) cycles in affected programs: 1093 > 1099 (0.55%) helped: 1 HURT: 1 helped stats (abs) min: 16 max: 16 x̄: 16.00 x̃: 16 helped stats (rel) min: 7.77% max: 7.77% x̄: 7.77% x̃: 7.77% HURT stats (abs) min: 22 max: 22 x̄: 22.00 x̃: 22 HURT stats (rel) min: 2.48% max: 2.48% x̄: 2.48% x̃: 2.48% Signedoffby: Ian Romanick <ian.d.romanick@intel.com> Reviewedby: Thomas Helland <thomashelland90@gmail.com>

Ian Romanick authored
All Gen6+ platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277184 > 14276964 (<.01%) instructions in affected programs: 10082 > 9862 (2.18%) helped: 37 HURT: 1 helped stats (abs) min: 1 max: 30 x̄: 5.97 x̃: 4 helped stats (rel) min: 0.14% max: 16.00% x̄: 5.23% x̃: 2.04% HURT stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 HURT stats (rel) min: 0.70% max: 0.70% x̄: 0.70% x̃: 0.70% 95% mean confidence interval for instructions value: 7.87 3.71 95% mean confidence interval for instructions %change: 6.98% 3.16% Instructions are helped. total cycles in shared programs: 532577990 > 532577062 (<.01%) cycles in affected programs: 170959 > 170031 (0.54%) helped: 33 HURT: 9 helped stats (abs) min: 2 max: 120 x̄: 30.91 x̃: 30 helped stats (rel) min: 0.02% max: 7.65% x̄: 2.66% x̃: 1.13% HURT stats (abs) min: 2 max: 24 x̄: 10.22 x̃: 8 HURT stats (rel) min: 0.09% max: 1.79% x̄: 0.61% x̃: 0.22% 95% mean confidence interval for cycles value: 31.23 12.96 95% mean confidence interval for cycles %change: 2.90% 1.02% Cycles are helped. Iron Lake and GM45 had similar results. (Iron Lake shown) total instructions in shared programs: 7781539 > 7781301 (<.01%) instructions in affected programs: 10169 > 9931 (2.34%) helped: 32 HURT: 0 helped stats (abs) min: 2 max: 20 x̄: 7.44 x̃: 6 helped stats (rel) min: 0.47% max: 17.02% x̄: 4.03% x̃: 1.88% 95% mean confidence interval for instructions value: 9.53 5.34 95% mean confidence interval for instructions %change: 5.94% 2.12% Instructions are helped. total cycles in shared programs: 177878590 > 177878932 (<.01%) cycles in affected programs: 78706 > 79048 (0.43%) helped: 7 HURT: 21 helped stats (abs) min: 6 max: 34 x̄: 24.57 x̃: 28 helped stats (rel) min: 0.15% max: 8.33% x̄: 4.66% x̃: 6.37% HURT stats (abs) min: 2 max: 86 x̄: 24.48 x̃: 22 HURT stats (rel) min: 0.01% max: 4.28% x̄: 1.21% x̃: 0.70% 95% mean confidence interval for cycles value: 0.30 24.13 95% mean confidence interval for cycles %change: 1.52% 1.01% Inconclusive result (%change mean confidence interval includes 0). v2: s/fmin/fmax/. Noticed by Thomas Helland. Signedoffby: Ian Romanick <ian.d.romanick@intel.com> Reviewedby: Thomas Helland <thomashelland90@gmail.com>
