- 06 Jan, 2021 23 commits
-
-
Danylo Piliaiev authored
All necessary features are already supported. GL33 CTS failures: KHR-GL33.texture_swizzle.smoke - timeouts, passes otherwise KHR-GL33.cull_distance.coverage - see https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/2673 fix is not in the public repo yet. Signed-off-by:
Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <mesa/mesa!8270>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Eric Anholt <eric@anholt.net> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Rob Clark <robdclark@chromium.org> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Rob Clark <robdclark@chromium.org> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Eric Anholt <eric@anholt.net> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Eric Anholt <eric@anholt.net> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Eric Anholt <eric@anholt.net> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!8295>
-
Christian Gmeiner authored
Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!8295>
-
Mike Blumenkrantz authored
it's important to be able to tell whether this is explicitly set by the user Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <!7489>
-
Erik Faye-Lund authored
fcsel is only emitted by bool -> float lowering. We used to do that a long time ago, but no longer. So we don't need to support this opcode any longer. Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <!8347>
-
Erik Faye-Lund authored
We recently added two versions of these options, due to soft-fp support. So let's also add the lowering to the soft-fp version. Fixes: 43302ead ("zink: use lower_scmp instead of open-coding") Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <!8347>
-
Boris Brezillon authored
The AFBC layout of RT/ZS-extension descriptors on Bifrost v6 matches the v7 one except for the Block Format field. Update the set_buf() functions accordingly. Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!8328>
-
Yogesh Mohan Marmithu authored
Enable vrs2x2 coarse shading if flat shading as per idea and guidance given by Marek. is_flat_shading variable in struct si_shader_info is set based on the data from gather_intrinsic_info() function and struct si_state_rasterizer. If is_flat_shading_variable is set, then in function si_emit_db_render_state() vrs2x2 shading is enabled in hardware. v2: Fix review comments from Pierre-Eric. Code optimizations. v3: Fix indentation style issue. v4: Fix review comments from Marek. Fixed logical issue pointed by Marek where info->is_flat_shading variable can be corrupted and other code cleanup. v5: Make the code compact as suggested by Pierre-Eric. v6: Fix new review comments from Marek. v7: use info->uses_interp_color variable fix from Marek. v8: Fix coding style comment from Marek. v9: Add uses_fbfetch_output check as suggested by Marek. Signed-off-by:
Yogesh Mohan Marimuthu <yogesh.mohanmarimuthu@amd.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!8161>
-
- 05 Jan, 2021 17 commits
-
-
Eric Anholt authored
We needed to do this anyway to finish enabling NTT in general, but more importantly: when we enabled sending NIR to the draw module, that broke PIPE_CAP_LOAD_CONSTBUF drivers in the select/feedback paths if LLVM was disabled. Fixes: 44b7e149 ("st/mesa: don't generate TGSI for the draw VS because it now supports NIR too") (along with the rest of this MR) Closes: #3996Acked-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!8196>
-
Eric Anholt authored
I had a funny +1 in nir_to_tgsi's load_ubo lowering on the buffer index, because I hadn't set lower_uniform_to_ubo for softpipe. This removes that weirdness in favor of just using lower_uniform_to_ubo, regardless of driver preference (which matters if a NIR-native driver had it set, and then the gallium draw module triggered the non-LLVM TGSI fallback path that hit NTT). Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!8196>
-
Eric Anholt authored
It was off by one due to some copy and paste from UBO handling. Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!8196>
-
Eric Anholt authored
Fixes: d70fff99 ("nir: Use a single list for all shader variables") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!8196>
-
Eric Anholt authored
Now that we can end up in nir-to-tgsi in the draw fallback paths of drivers with that flag set, we need to support it. Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!8196>
-
Eric Anholt authored
It was OK because right now we only execute in the first channel of the CS, but if you wanted to extend that then you'd need to check each channel. We already had what we needed for SSBOs, so just reuse it. Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!8196>
-
Eric Anholt authored
GL by default gives you UB when you access a missing constbuf, and we were crashing on debug builds in that case. More importantly, we were assertion failing even under valid circumstances, when a !ExecMask channel had a bad value for the indirect buffer index and we tried to load from it anyway. In removing the assertion, also sink the buf declaration to after we've done the bounds check that determines that there's a constbuf actually bound to this index. Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!8196>
-
Jesse Natalie authored
There's not really a reason to directly map textures. Doing so requires the texture to be allocated in system RAM instead of video RAM, which means all GPU access to it would be needlessly slow. Notably, the one texture type that was allocated this way is the display target texture for the software driver path. Instead, use pipe_transfer_map to be able to copy the texture to system RAM. Reviewed-by:
Louis-Francis Ratté-Boulianne <lfrb@collabora.com> Part-of: <!8095>
-
Jesse Natalie authored
Reviewed-by:
Louis-Francis Ratté-Boulianne <lfrb@collabora.com> Part-of: <!8095>
-
Jesse Natalie authored
For non-CPU-accessible pipe resource types (DEFAULT/IMMUTABLE), allocate non-CPU-accessible buffers directly from the cache_bufmgr. Update the d3d12_bo creation to handle nonmappable buffers. For CPU-write-only (DYNAMIC/STREAM), use the upload slab_bufmgr. Update this slab manager to use CPU_WRITE | GPU_READ PB usage. For CPU-read-write (STAGING), use the readback_slab_bufmgr. Reviewed-by:
Louis-Francis Ratté-Boulianne <lfrb@collabora.com> Part-of: <!8095>
-
Jesse Natalie authored
Readback (GPU write, CPU read) should use different CPU page properties compared to upload (write-back vs write-combined). A future commit will start to respect these PB usage flags. Reviewed-by:
Louis-Francis Ratté-Boulianne <lfrb@collabora.com> Part-of: <!8095>
-
Jesse Natalie authored
Currently all buffers are allocated as mappable, but a future commit will change that so that some buffers can be allocated directly in non-CPU-accessible memory for improved performance. Note that the returned pointer must be appropriately offset from a 64-byte-aligned base pointer, so if offsets are used, the data will be read/written to an offset region in the staging buffer. Reviewed-by:
Louis-Francis Ratté-Boulianne <lfrb@collabora.com> Part-of: <!8095>
-
Jesse Natalie authored
The mantissa for a float doesn't contain enough data to accurately represent the min/max values for some destination types. Instead of clamping before converting, clamp after converting when coming from floats. This improves conformance of CL conversions, specifically for float -> long/ulong with int64 emulation enabled. Refactors the limit determination from the clamp, so we can determine limits for the dest type (int/uint) in both the source (float) and dest type. The limit as a float is used for comparison, while the limit as a dest type is used for bcsel. Important note is that the comparison is inverted to fge instead of flt, so the bcsel chooses the direct int/uint over the converted float in the case where the comparison comes up equal, but the conversion can't produce the exact min/max value. Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!8256>
-
Eric Anholt authored
Since we've got issues on a5xx xfb that we don't on a6xx, I've been looking at making them line up a bit better. No change on tests. Part-of: <!8336>
-
Eric Anholt authored
The link function just loops over the num_outputs. Brings us closer to a6xx. Part-of: <!8336>
-
Eric Anholt authored
All 3 copies were the same other than style tweaks. Part-of: <!8336>
-
Erik Faye-Lund authored
We already have the proper lowering in NIR for this, so there's no point in doing our own implementations of these. The end result is the same code anyway. Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <!8335>
-