1. 07 Mar, 2020 1 commit
  2. 06 Mar, 2020 20 commits
  3. 25 Feb, 2020 1 commit
    • José Casanova Crespo's avatar
      v3d: Sync on last CS when non-compute stage uses resource written by CS · e1dc5cc7
      José Casanova Crespo authored
      When a resource is written by a compute shader and then used by a
      non-compute stage we sync on last compute job to guarantee that the
      resource has been completely written when the next stage reads resources.
      
      In the other cases how flushes are done guarantee the serialization of
      the writes and reads.
      
      To reproduce the failure the following tests should be executed in batch
      as last test don't fail when run isolated:
      
      KHR-GLES31.core.shader_image_load_store.basic-allFormats-load-fs
      KHR-GLES31.core.shader_image_load_store.basic-allFormats-loadStoreComputeStage
      KHR-GLES31.core.shader_image_load_store.basic-allTargets-load-cs
      KHR-GLES31.core.shader_image_load_store.advanced-sync-vertexArray
      
      v2: Use fence dep instead of bo_wait (Eric Anholt)
      v3: Rename struct names (Iago Toral)
          Document why is not needed on graphics->compute case. (Iago Toral)
          Follow same code pattern of the other update of in_sync_bcl.
      v4: Fixed comments style. (Iago Toral)
      
      Fixes KHR-GLES31.core.shader_image_load_store.advanced-sync-vertexArray
      Reviewed-by: Iago Toral's avatarIago Toral Quiroga <itoral@igalia.com>
      CC: 19.3 20.0 <mesa-stable@lists.freedesktop.org>
      Tested-by: Marge Bot <!2700>
      Part-of: <!2700>
      (cherry picked from commit 01496e3d)
      e1dc5cc7
  4. 24 Feb, 2020 2 commits
  5. 20 Feb, 2020 5 commits
  6. 18 Feb, 2020 4 commits
  7. 14 Feb, 2020 2 commits
  8. 13 Feb, 2020 2 commits
  9. 11 Feb, 2020 3 commits
    • Samuel Pitoiset's avatar
      nir: do not use De Morgan's Law rules for flt and fge · 42e7b158
      Samuel Pitoiset authored
      In presence of NaNs, "!(flt(a, b) && flt(c, d))" is NOT EQUAL
      to "fge(a, b) || fge(c, d)". These optimizations are unsafe for
      apps that rely on NaN behaviour.
      
      pipeline-db (GFX9/LLVM):
      Totals from affected shaders:
      SGPRS: 3176 -> 3136 (-1.26 %)
      VGPRS: 2188 -> 2144 (-2.01 %)
      Spilled SGPRs: 227 -> 169 (-25.55 %)
      Code Size: 150572 -> 151800 (0.82 %) bytes
      Max Waves: 307 -> 310 (0.98 %)
      
      pipeline-db (GFX9/ACO):
      Totals from affected shaders:
      SGPRS: 18744 -> 18744 (0.00 %)
      VGPRS: 15576 -> 15580 (0.03 %)
      Spilled SGPRs: 164 -> 164 (0.00 %)
      Code Size: 1573012 -> 1576492 (0.22 %) bytes
      Max Waves: 1534 -> 1532 (-0.13 %)
      
      Closes: #2127
      Fixes: d1ed4ffe ("nir: Use De Morgan's Law on logic compounded comparisons")
      Signed-off-by: Samuel Pitoiset's avatarSamuel Pitoiset <samuel.pitoiset@gmail.com>
      Reviewed-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Tested-by: Marge Bot <!3696>
      Part-of: <!3696>
      (cherry picked from commit 8e772807)
      42e7b158
    • Eric Anholt's avatar
      Revert "gallium: Fix big-endian addressing of non-bitmask array formats." · 8f630dc7
      Eric Anholt authored
      This reverts the functional part of commit
      d17ff2f7, leaving the unit test for
      mesa/pipe agreement on what's an array.
      
      The issue is that the util_channel_desc.shift values on array formats are
      not used for bit addressing in memory, they're bit addressing within a
      word treating a pixel of the format as a native type, as seen by
      llvmpipe's use of the values to do shifts (see
      lp_build_unpack_arith_rgba_aos() for example).  This means the values are
      nonsensical for 3-byte RGB, but then llvmpipe doesn't expose those formats
      so it works out.
      
      I still want to clean up our big-endian format handling at some point, but
      let's fix the s390x regression first, sort out our format unit tests in
      CI, then be able to refactor with confidence.
      
      Fixes: d17ff2f7 ("gallium: Fix big-endian addressing of non-bitmask array formats.")
      Closes: #2472Acked-by: default avatarMarek Olšák <marek.olsak@amd.com>
      Tested-by: Marge Bot <!3721>
      Part-of: <!3721>
      (cherry picked from commit 1886dbfe)
      8f630dc7
    • Marek Olšák's avatar
      radeonsi: fix the DCC MSAA bug workaround · 007013c7
      Marek Olšák authored
      Cc: 19.3 20.0 <mesa-stable@lists.freedesktop.org>
      Reviewed-by: Bas Nieuwenhuizen's avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
      Part-of: <!3646>
      (cherry picked from commit fbb27eeb)
      007013c7