Commit d9d6305b authored by Kenneth Graunke's avatar Kenneth Graunke

st/mesa: Increase GL_POINT_SIZE_RANGE minimum to 1.0

Table 23.54 of the OpenGL 4.5 spec lists the minimum values for
GL_POINT_SIZE_RANGE as [1, 1].  So zero is not allowed (even though
arguably this could be useful for MSAA rendering, where a sub-1px
point might cover only some samples...)

This fixes the WebGL 2.0 conformance suite's test
on Chromium on Linux, which uses desktop OpenGL.  The test checks that
the minimum value of GL_ALIASED_POINT_SIZE_RANGE is 1.  Unfortunately,
that query doesn't exist in desktop GL, so it checks POINT_SIZE_RANGE,
which is the anti-aliased value.  There's not really anything better
for Chromium to do here, unfortunately.  When running Chromium with
--api=es3, it maps it to the correct query and the test already works.
Reviewed-by: Jordan Justen's avatarJordan Justen <>
Reviewed-by: Eric Anholt's avatarEric Anholt <>
parent fbad42bb
Pipeline #64058 passed with stages
in 17 minutes and 54 seconds
......@@ -132,11 +132,8 @@ void st_init_limits(struct pipe_screen *screen,
c->MaxPointSizeAA =
_maxf(1.0f, screen->get_paramf(screen, PIPE_CAPF_MAX_POINT_WIDTH_AA));
/* these are not queryable. Note that GL basically mandates a 1.0 minimum
* for non-aa sizes, but we can go down to 0.0 for aa points.
c->MinPointSize = 1.0f;
c->MinPointSizeAA = 0.0f;
c->MinPointSizeAA = 1.0f;
c->MaxTextureMaxAnisotropy =
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment