Commit bf76f2b2 authored by Lionel Landwerlin's avatar Lionel Landwerlin Committed by Dylan Baker
Browse files

anv: fix descriptor pool leak in VMA object

Quoting the spec :

   "When a pool is destroyed, all descriptor sets allocated from the
    pool are implicitly freed and become invalid. Descriptor sets
    allocated from a given pool do not need to be freed before
    destroying that descriptor pool."

This implies we might leak nodes allocated in the vma object.
Signed-off-by: Lionel Landwerlin's avatarLionel Landwerlin <>
Fixes: 0a6d2593

 ("anv: Allocate descriptor buffers from the BO cache")
Reviewed-by: Jason Ekstrand's avatarJason Ekstrand <>
Part-of: <!7796>
(cherry picked from commit 5d55ca9c)
parent 09980486
......@@ -1912,7 +1912,7 @@
"description": "anv: fix descriptor pool leak in VMA object",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "0a6d2593b8b63d2429e79eed900848c5c9a522c9"
......@@ -909,8 +909,10 @@ void anv_DestroyDescriptorPool(
anv_descriptor_set_layout_unref(device, set->layout);
if (pool->bo)
if (pool->bo) {
anv_device_release_bo(device, pool->bo);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment